Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Solution #27

wants to merge 3 commits into from

Conversation

alheimurin-n
Copy link

No description provided.

Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good only fix EoF

- "todoapp"
topologyKey: "kubernetes.io/hostname"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last line is not empty, so EoF didn't display corect. Remove space
image

bootstrap.sh Outdated
kubectl apply -f todoapp-deployment.yml

# Verify everything is running
kubectl get all --all-namespaces

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed EoF

Copy link

@Alkaponees Alkaponees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my recommendation

.infrastructure/app/deployment.yml Outdated Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check description to task and fix paths and files' name

Copy link

@Alkaponees Alkaponees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants