Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #4603

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add task solution #4603

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa161fd
add task solution
GabrielNunes-383 Nov 17, 2024
064ca27
add task solution
GabrielNunes-383 Nov 17, 2024
7f4e000
add task solution
GabrielNunes-383 Nov 17, 2024
8e22dfe
add task solution
GabrielNunes-383 Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added src/fonts/AvenirLTStd-Book.woff2
View file
Open in desktop
Binary file not shown.
Binary file added src/images/Icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 5 additions & 2 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,21 @@
rel="stylesheet"
href="style.css"
/>

</head>
<body>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
class="input input_item-1"
/>

<br>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <br> tag should be self-closing like <br /> to maintain consistency with the XHTML style used in the rest of the document.

<input
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
placeholder="Los Angeles"
class="input input_item-2"
/>
</body>
</html>
73 changes: 73 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,74 @@
/* add styles here */
@font-face {
font-family: Avenir;
src: url(fonts/AvenirLTStd-Book.woff2) format('woff2');
font-weight: 400;
font-style: normal;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing:

* {
  box-sizing: border-box;
}

html {
font-family: Avenir, sans-serif;
font-weight: 400;
}

input::placeholder {
font-family: Avenir, sans-serif;
font-weight: 400;
color: #3D4E61;
}



.input {
background-image: url(images/Icon.png);
background-repeat: no-repeat;
background-position: 5px;
padding-left: 30px;
border-radius: 3px;
border: 1px solid #E1E7ED;
font-size: 16px;
}

.input_item-1 {
width: 900px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width: 100%

height: 70px;
top: 71px;
left: 48px;
Comment on lines +36 to +37
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'top' and 'left' properties are used here, but they have no effect unless the element is positioned (e.g., relative, absolute, fixed). Consider removing these properties or setting a position for the element.

margin-top: 20px;
margin-bottom: 20px;
box-shadow: 0 1px 8px 0 #3D4E611A;

}

.input_item-2 {
width: 427px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width: 100%

height: 42px;
top: 403px;
left: 48px;
Comment on lines +48 to +49
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, the 'top' and 'left' properties will not affect the element unless it has a specified position. Consider removing these properties or setting a position for the element.

font-size: 14px;
text-shadow: 0 4px 4px 0 #00000040;

}

.input_item-1:hover {
box-shadow: 0 4px 4px 0 #00000040;
}

.input_item-1:focus {
background: linear-gradient(180deg, #FFF 0%, #F6F6F7 100%);
box-shadow: 0 4px 4px 0 #00000040;
text-shadow: 0 4px 4px 0 #00000040;
color: #3D4E61;
}

.input_item-2:hover {
text-shadow: none;
box-shadow: 0 3px 8px 0 #3D4E6133;
}

.input_item-2:focus {
background: linear-gradient(180deg, #FFF 0%, #F6F6F7 100%);
font-weight: 900;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-weight for .input_item-2:focus is set to 900, which may not align with the task requirements. Ensure that the font-weight matches the specifications provided in the task description.

color: #3D4E61;
}

Loading