Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution the challenger search-bar airbnb #4604

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution the challenger search-bar airbnb #4604

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d9eee2
Solution the challenger search-bar airbnb
MannyShussan Nov 17, 2024
8c0e0ba
Fix of HTML
MannyShussan Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ ___

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_search-bar-airbnb/report/html_report/)
- [DEMO LINK](https://MannyShussan.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://MannyShussan.github.io/layout_search-bar-airbnb/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
37 changes: 26 additions & 11 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,31 @@
/>
</head>
<body>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>

<input
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
/>
<div class="inputs">
<form
class="inputs__form"
action="post"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action attribute in the form tag should specify a URL where the form data will be sent. Currently, it is set to 'post', which is incorrect. Consider changing it to a valid URL or leaving it empty if the form is handled by JavaScript.

data-qa="keypress"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data-qa attribute is incorrectly assigned as 'keypress'. Ensure that the data-qa attribute correctly identifies the form as per the requirements.

>
<input
class="inputs__bigInput"
type="text"
data-qa="big"
placeholder="Try “Los Angeles“"
/>
</form>
<form
class="inputs__form"
action="post"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous form, the action attribute should specify a URL. 'post' is not a valid URL. Adjust this to a proper URL or leave it empty if the form submission is managed by JavaScript.

data-qa="small"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data-qa attribute is incorrectly assigned as 'small'. Ensure that the data-qa attribute correctly identifies the form as per the requirements.

>
<input
class="inputs__smallInput"
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
/>
</form>
</div>
</body>
</html>
91 changes: 90 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,90 @@
/* add styles here */
/* stylelint-disable font-family-no-missing-generic-family-keyword */
/* stylelint-disable font-family-name-quotes */
@font-face {
font-family: 'Avenir';
src: url(fonts/Avenir.ttc);
font-weight: 300;
}

@font-face {
font-family: 'Avenir';
src: url(fonts/Avenir-Heavy.ttf);
font-weight: 900;
}

@font-face {
font-family: 'Avenir';
src: url(fonts/Avenir-Book.ttf);
font-weight: 400;
}

.html {
font-family: 'Avenir';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector .html seems to be incorrect if the intention is to style the HTML element. It should be html without the dot, as .html targets a class named 'html'.

font-weight: 300;
}

.inputs {
display: flex;
flex-direction: column;
gap: 20px;
margin-top: 20px;
}

.inputs__bigInput {
width: 100%;
font-family: 'Avenir';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the .inputs__bigInput stretches the full width of the container. The current width: 100%; should achieve this, but verify it in the context of the container's styling.

font-size: 16px;
line-height: 150%;
height: 70px;
color: #3d4e61;
background-image: url(images/Search.svg);
background-repeat: no-repeat;
background-size: 19px 19px;
border: 1px solid #e1e7ed;
border-radius: 4px;
box-sizing: border-box;
background-position: 25px;
padding: 0 0 0 62px;
outline: none;
}

.inputs__bigInput:hover {
box-shadow: 0 4px 4px 0 #00000040;
}

.inputs__bigInput:focus {
font-weight: 900;
box-shadow: 0 4px 4px 0 #00000040;
text-shadow: 0 4px 4px 0 #00000040;
}

.inputs__smallInput {
width: 100%;
font-family: 'Avenir';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the .inputs__smallInput stretches the full width of the container. The current width: 100%; should achieve this, but verify it in the context of the container's styling.

font-size: 14px;
font-weight: 400;
line-height: 150%;
height: 42px;
color: #3d4e61;
background-image: url(images/Search.svg);
background-repeat: no-repeat;
background-size: 11px 11px;
border: 1px solid #e1e7ed;
border-radius: 4px;
box-sizing: border-box;
background-position: 13px;
padding: 0 0 0 33px;
outline: none;
}

input::placeholder {
color: #3d4e61;
}

.inputs__smallInput:hover {
box-shadow: 0 4px 4px 0 #00000040;
}

.inputs__smallInput:focus {
font-weight: 900;
}
Loading