-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #3638
base: master
Are you sure you want to change the base?
add solution #3638
Conversation
in4ik1303
commented
Feb 18, 2025
- DEMO LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:
-
Animation Duration for Speed-Up Modifier: The
stopwatch--speed-up
modifier should correctly change theanimation-duration
for both the minute and second hands. Currently, it's only set for thestopwatch
class, which might not apply the speed-up effect as intended. Please ensure both hands have their durations set to10s
and10min
respectively. -
BEM Modifier Implementation: Make sure the
stopwatch--speed-up
modifier is applied correctly in the HTML for testing purposes, and that it adjusts the animation durations as required. -
SCSS Syntax: There's a minor syntax issue with the
rotate
property in the SCSS file. It should berotate: 0;
instead ofrotate: (0);
.
Once these issues are resolved, your solution will be in great shape! Keep up the great work, and don't hesitate to reach out if you need any help. 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/styles/index.scss
Outdated
animation-iteration-count: infinite; | ||
animation-duration: 3600s; | ||
transform-origin: bottom; | ||
rotate: (0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'rotate' property should not have parentheses. It should be 'rotate: 0;' instead of 'rotate: (0);'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job on addressing the previous issues and implementing the stopwatch--speed-up
modifier correctly! 🎉 Your solution now meets the task requirements, and the animation durations for both the minute and second hands are set as expected. The BEM modifier is applied correctly in the HTML, and the syntax issue with the rotate
property has been fixed.
However, there are still some minor syntax issues in the SCSS file that need attention. Specifically, ensure that the rotate
function is used correctly without spaces, as in transform: rotate(0);
.
Your code is approved to help you move forward with your learning journey. Please review the comments and address these minor issues to improve your code quality. Remember, attention to detail is crucial, and fixing these will help you avoid similar problems in the future. Keep up the good work and continue learning from your mistakes! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
animation-iteration-count: infinite; | ||
animation-duration: 3600s; | ||
transform-origin: bottom; | ||
transform: rotate (0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error here. The rotate
function should not have a space between rotate
and the parentheses. It should be transform: rotate(0);
.
animation-timing-function: linear; | ||
animation-iteration-count: infinite; | ||
animation-name: go; | ||
transform: rotate (0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to line 38, there is a syntax error here. The rotate
function should not have a space between rotate
and the parentheses. It should be transform: rotate(0);
.