watch #3644
Open
watch #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Great job! 🎉 Your code meets all the task requirements and constraints effectively. The HTML and SCSS files are well-structured, and the animations are implemented correctly. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
volodymyr-soltys97
suggested changes
Feb 20, 2025
src/styles/index.scss
Outdated
Comment on lines
55
to
71
| @keyframes second-rotation { | ||
| 0% { | ||
| transform: translate(-50%, -100%) rotate(0deg); | ||
| } | ||
| 100% { | ||
| transform: translate(-50%, -100%) rotate(360deg); | ||
| } | ||
| } | ||
|
|
||
| @keyframes minute-rotation { | ||
| 0% { | ||
| transform: translate(-50%, -100%) rotate(0deg); | ||
| } | ||
| 100% { | ||
| transform: translate(-50%, -100%) rotate(360deg); | ||
| } | ||
| } |
There was a problem hiding this comment.
Don't need to duplicate key frames with the same scenario
Suggested change
| @keyframes second-rotation { | |
| 0% { | |
| transform: translate(-50%, -100%) rotate(0deg); | |
| } | |
| 100% { | |
| transform: translate(-50%, -100%) rotate(360deg); | |
| } | |
| } | |
| @keyframes minute-rotation { | |
| 0% { | |
| transform: translate(-50%, -100%) rotate(0deg); | |
| } | |
| 100% { | |
| transform: translate(-50%, -100%) rotate(360deg); | |
| } | |
| } | |
| @keyframes rotation { | |
| 0% { | |
| transform: translate(-50%, -100%) rotate(0deg); | |
| } | |
| 100% { | |
| transform: translate(-50%, -100%) rotate(360deg); | |
| } | |
| } |
src/index.html
Outdated
| @@ -17,6 +17,10 @@ | |||
| /> | |||
| </head> | |||
| <body> | |||
| <h1>Stop watch</h1> | |||
| <div class="stopwatch"> | |||
There was a problem hiding this comment.
Add the modifier class here .stopwatch--speed-up
Diana2369
requested review from
mateacademy-ai-mentor and
volodymyr-soltys97
vadiimvooo
approved these changes
Feb 20, 2025
Comment on lines
+55
to
+71
| @keyframes second-rotation { | ||
| from { | ||
| transform: translate(-50%, -100%) rotate(0deg); | ||
| } | ||
| to { | ||
| transform: translate(-50%, -100%) rotate(360deg); | ||
| } | ||
| } | ||
|
|
||
| @keyframes minute-rotation { | ||
| from { | ||
| transform: translate(-50%, -100%) rotate(0deg); | ||
| } | ||
| to { | ||
| transform: translate(-50%, -100%) rotate(360deg); | ||
| } | ||
| } |
There was a problem hiding this comment.
just use single keyframe for both hands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗️ Replace <your_account> with your GitHub username and copy the links to the Pull Request description:
DEMO LINK
❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.