-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #3646
base: master
Are you sure you want to change the base?
Develop #3646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the stopwatch component! 🎉 The structure and animations are well done. There's a minor issue with the BEM naming convention and a small syntax detail in the transform
property, but these don't impact the functionality. Keep up the good work and consider refining these details for even cleaner code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
animation-iteration-count: infinite; | ||
animation-duration: 3600s; | ||
transform-origin: bottom; | ||
transform: rotate (0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra space between 'rotate' and '(0)' in the transform property. It should be 'rotate(0)'.
animation-timing-function: linear; | ||
animation-iteration-count: infinite; | ||
animation-name: go; | ||
transform: rotate (0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra space between 'rotate' and '(0)' in the transform property. It should be 'rotate(0)'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task! 🎉 The functionality is intact, and the core requirements are met. The only minor issue is the extra space in the transform
property, which doesn't affect the functionality but is good to fix for consistency. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
animation-iteration-count: infinite; | ||
animation-duration: 3600s; | ||
transform-origin: bottom; | ||
transform: rotate (0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra space between 'rotate' and '(0)'. It should be 'rotate(0)' without any space to ensure the transform property is applied correctly.
animation-timing-function: linear; | ||
animation-iteration-count: infinite; | ||
animation-name: go; | ||
transform: rotate (0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to line 39, there is an extra space between 'rotate' and '(0)'. It should be 'rotate(0)' without any space.
Typical Mistakes
from theBEM
lesson theory are checked.