Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #3646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Develop #3646

wants to merge 1 commit into from

Conversation

taynaraj
Copy link

  • DEMO LINK
  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the stopwatch component! 🎉 The structure and animations are well done. There's a minor issue with the BEM naming convention and a small syntax detail in the transform property, but these don't impact the functionality. Keep up the good work and consider refining these details for even cleaner code in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

animation-iteration-count: infinite;
animation-duration: 3600s;
transform-origin: bottom;
transform: rotate (0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space between 'rotate' and '(0)' in the transform property. It should be 'rotate(0)'.

animation-timing-function: linear;
animation-iteration-count: infinite;
animation-name: go;
transform: rotate (0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space between 'rotate' and '(0)' in the transform property. It should be 'rotate(0)'.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task! 🎉 The functionality is intact, and the core requirements are met. The only minor issue is the extra space in the transform property, which doesn't affect the functionality but is good to fix for consistency. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

animation-iteration-count: infinite;
animation-duration: 3600s;
transform-origin: bottom;
transform: rotate (0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space between 'rotate' and '(0)'. It should be 'rotate(0)' without any space to ensure the transform property is applied correctly.

animation-timing-function: linear;
animation-iteration-count: infinite;
animation-name: go;
transform: rotate (0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to line 39, there is an extra space between 'rotate' and '(0)'. It should be 'rotate(0)' without any space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants