Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #776

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
### Python ###
*.py[cod]
*$py.class
*.so
__pycache__/

### Django ###
*.log
*.pot
local_settings.py
db.sqlite3
db.sqlite3-journal
media/

### Virtual Environments ###
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/

### PyCharm ###
.idea/
.idea/**/workspace.xml
.idea/**/tasks.xml
.idea/**/usage.statistics.xml
.idea/**/dictionaries
.idea/**/shelf

### Unit test / coverage reports ###
htmlcov/
.tox/
.nox/
.coverage
.coverage.*
.pytest_cache/
Empty file added app/__init__.py
Empty file.
16 changes: 16 additions & 0 deletions app/asgi.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
"""
ASGI config for app project.

It exposes the ASGI callable as a module-level variable named ``application``.

For more information on this file, see
https://docs.djangoproject.com/en/5.1/howto/deployment/asgi/
"""

import os

from django.core.asgi import get_asgi_application

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "app.settings")

application = get_asgi_application()
128 changes: 128 additions & 0 deletions app/settings.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
"""
Django settings for app project.

Generated by 'django-admin startproject' using Django 5.1.3.

For more information on this file, see
https://docs.djangoproject.com/en/5.1/topics/settings/

For the full list of settings and their values, see
https://docs.djangoproject.com/en/5.1/ref/settings/
"""

from pathlib import Path

# Build paths inside the project like this: BASE_DIR / 'subdir'.
BASE_DIR = Path(__file__).resolve().parent.parent


# Quick-start development settings - unsuitable for production
# See https://docs.djangoproject.com/en/5.1/howto/deployment/checklist/

# SECURITY WARNING: keep the secret key used in production secret!
SECRET_KEY = "django-insecure-9bl-h(4lgo@ze7&)49dh0p#361_foxihsxdhud*@v)svfj&%@9"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SECRET_KEY is hardcoded and should not be exposed in the source code, especially if this code is pushed to a public repository. Consider using environment variables to securely manage sensitive information.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Issue: The SECRET_KEY is hardcoded. It's recommended to use environment variables to manage sensitive information securely.


# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = True

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DEBUG setting is set to True. This should be set to False in a production environment to avoid exposing sensitive information.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Issue: DEBUG is set to True. This should be set to False in a production environment to prevent exposing sensitive information.


ALLOWED_HOSTS = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ALLOWED_HOSTS list is empty. In a production environment, you should specify the host/domain names that this Django site can serve.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration Issue: The ALLOWED_HOSTS list is empty. In production, you should specify the host/domain names that your Django site can serve.



# Application definition

INSTALLED_APPS = [
"django.contrib.admin",
"django.contrib.auth",
"django.contrib.contenttypes",
"django.contrib.sessions",
"django.contrib.messages",
"django.contrib.staticfiles",
"rest_framework",
"cinema",
"user"
]

AUTH_USER_MODEL = "user.User"

MIDDLEWARE = [
"django.middleware.security.SecurityMiddleware",
"django.contrib.sessions.middleware.SessionMiddleware",
"django.middleware.common.CommonMiddleware",
"django.middleware.csrf.CsrfViewMiddleware",
"django.contrib.auth.middleware.AuthenticationMiddleware",
"django.contrib.messages.middleware.MessageMiddleware",
"django.middleware.clickjacking.XFrameOptionsMiddleware",
]

ROOT_URLCONF = "app.urls"

TEMPLATES = [
{
"BACKEND": "django.template.backends.django.DjangoTemplates",
"DIRS": [],
"APP_DIRS": True,
"OPTIONS": {
"context_processors": [
"django.template.context_processors.debug",
"django.template.context_processors.request",
"django.contrib.auth.context_processors.auth",
"django.contrib.messages.context_processors.messages",
],
},
},
]

WSGI_APPLICATION = "app.wsgi.application"


# Database
# https://docs.djangoproject.com/en/5.1/ref/settings/#databases

DATABASES = {
"default": {
"ENGINE": "django.db.backends.sqlite3",
"NAME": BASE_DIR / "db.sqlite3",
}
}


# Password validation
# https://docs.djangoproject.com/en/5.1/ref/settings/#auth-password-validators

AUTH_PASSWORD_VALIDATORS = [
{
"NAME": "django.contrib.auth.password_validation.UserAttributeSimilarityValidator",
},
{
"NAME": "django.contrib.auth.password_validation.MinimumLengthValidator",
},
{
"NAME": "django.contrib.auth.password_validation.CommonPasswordValidator",
},
{
"NAME": "django.contrib.auth.password_validation.NumericPasswordValidator",
},
]


# Internationalization
# https://docs.djangoproject.com/en/5.1/topics/i18n/

LANGUAGE_CODE = "en-us"

TIME_ZONE = "UTC"

USE_I18N = True

USE_TZ = True


# Static files (CSS, JavaScript, Images)
# https://docs.djangoproject.com/en/5.1/howto/static-files/

STATIC_URL = "static/"

# Default primary key field type
# https://docs.djangoproject.com/en/5.1/ref/settings/#default-auto-field

DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
23 changes: 23 additions & 0 deletions app/urls.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
"""
URL configuration for app project.

The `urlpatterns` list routes URLs to views. For more information please see:
https://docs.djangoproject.com/en/5.1/topics/http/urls/
Examples:
Function views
1. Add an import: from my_app import views
2. Add a URL to urlpatterns: path('', views.home, name='home')
Class-based views
1. Add an import: from other_app.views import Home
2. Add a URL to urlpatterns: path('', Home.as_view(), name='home')
Including another URLconf
1. Import the include() function: from django.urls import include, path
2. Add a URL to urlpatterns: path('blog/', include('blog.urls'))
"""
from django.contrib import admin
from django.urls import path, include

urlpatterns = [
path("admin/", admin.site.urls),
path("api/cinema/", include("cinema.urls", namespace="cinema"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The include() function is used with a namespace argument, but the cinema.urls module must define an app_name variable for this to work correctly. Ensure that cinema/urls.py includes an app_name variable set to 'cinema'.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespace Issue: The include function is using a namespace argument, which requires the included URLconf to define an app_name attribute. Ensure that the cinema.urls module has an app_name defined, or remove the namespace argument if not needed.

]
16 changes: 16 additions & 0 deletions app/wsgi.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
"""
WSGI config for app project.

It exposes the WSGI callable as a module-level variable named ``application``.

For more information on this file, see
https://docs.djangoproject.com/en/5.1/howto/deployment/wsgi/
"""

import os

from django.core.wsgi import get_wsgi_application

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "app.settings")

application = get_wsgi_application()
Empty file added cinema/__init__.py
Empty file.
5 changes: 5 additions & 0 deletions cinema/admin.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from django.contrib import admin

from cinema.models import Movie

admin.site.register(Movie)
6 changes: 6 additions & 0 deletions cinema/apps.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
from django.apps import AppConfig


class CinemaConfig(AppConfig):
default_auto_field = "django.db.models.BigAutoField"
name = "cinema"
30 changes: 30 additions & 0 deletions cinema/migrations/0001_initial.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Generated by Django 5.1.4 on 2024-12-07 08:32

from django.db import migrations, models


class Migration(migrations.Migration):

initial = True

dependencies = []

operations = [
migrations.CreateModel(
name="Movie",
fields=[
(
"id",
models.BigAutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name="ID",
),
),
("title", models.CharField(max_length=255)),
("description", models.TextField()),
("duration", models.IntegerField()),
],
),
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Generated by Django 5.1.3 on 2024-12-08 16:04

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
("cinema", "0001_initial"),
]

operations = [
migrations.AlterField(
model_name="movie",
name="description",
field=models.CharField(blank=True, max_length=255),
),
migrations.AlterField(
model_name="movie",
name="title",
field=models.CharField(blank=True, max_length=255),
),
]
Empty file added cinema/migrations/__init__.py
Empty file.
10 changes: 10 additions & 0 deletions cinema/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from django.db import models


class Movie(models.Model):
title = models.CharField(max_length=255, blank=True)
description = models.CharField(max_length=255, blank=True)
duration = models.IntegerField()

def __str__(self):
return f"{self.title} duration: {self.duration} min"
21 changes: 21 additions & 0 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from rest_framework import serializers
from cinema.models import Movie


class MovieSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
title = serializers.CharField(max_length=255, required=False)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title field is marked as required=False, which means it is optional during serialization and deserialization. Ensure this aligns with your application's requirements, as it may allow creating or updating a Movie without a title.

description = serializers.CharField(required=False)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description field is also marked as required=False. Consider whether this field should be optional or required based on your application's needs.

Comment on lines +7 to +8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title and description fields are marked as required=False. Ensure this aligns with your application's requirements, as it may allow creating or updating a Movie without these fields.

duration = serializers.IntegerField()

def create(self, validated_data):
return Movie.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.title = validated_data.get("title", instance.title)
instance.description = validated_data.get(
"description", instance.description
)
instance.duration = validated_data.get("duration", instance.duration)
instance.save()
return instance
3 changes: 3 additions & 0 deletions cinema/tests.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from django.test import TestCase

# Create your tests here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding test cases to this file to verify the functionality of your models, views, and serializers. This will help ensure that your application behaves as expected and can handle edge cases.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests.py file is empty. It's important to implement test cases to ensure your application functions correctly and can handle edge cases. Consider adding tests for your models, views, and serializers.

13 changes: 13 additions & 0 deletions cinema/urls.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
from django.urls import path
from cinema.views import (
movie_list,
movie_detail,
)


app_name = "cinema"

urlpatterns = [
path("movies/", movie_list, name="movie-list"),
path("movies/<pk>/", movie_detail, name="movie-detail"),
]
37 changes: 37 additions & 0 deletions cinema/views.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@

from rest_framework.decorators import api_view
from rest_framework.generics import get_object_or_404
from rest_framework.response import Response
from rest_framework import status

from cinema.models import Movie
from cinema.serializers import MovieSerializer


@api_view(["GET", "POST"])
def movie_list(request):
if request.method == "GET":
movies = Movie.objects.all()
serializer = MovieSerializer(movies, many=True)
return Response(serializer.data, status=status.HTTP_200_OK)
else:
serializer = MovieSerializer(data=request.data)
serializer.is_valid(raise_exception=True)
serializer.save()
return Response(serializer.data, status=status.HTTP_201_CREATED)


@api_view(["GET", "PUT", "DELETE"])
def movie_detail(request, pk):
movie = get_object_or_404(Movie, pk=pk)
if request.method == "GET":
serializer = MovieSerializer(movie)
return Response(serializer.data, status=status.HTTP_200_OK)
elif request.method == "PUT":
serializer = MovieSerializer(movie, data=request.data)
serializer.is_valid(raise_exception=True)
serializer.save()
return Response(serializer.data, status=status.HTTP_200_OK)
else:
movie.delete()
return Response(status=status.HTTP_204_NO_CONTENT)
Loading