Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BLoC folder icon #2795

Closed
wants to merge 2 commits into from
Closed

feat: add BLoC folder icon #2795

wants to merge 2 commits into from

Conversation

PKief
Copy link
Member

@PKief PKief commented Jan 6, 2025

Description

Added BLoC folder icon.

Closes #2585.
Closes #1461.

Follow-up of #2586.

Contribution Guidelines

@github-actions github-actions bot added the 🏞️ icons PR with new icons label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief PKief mentioned this pull request Jan 6, 2025
2 tasks
@nulkode
Copy link
Contributor

nulkode commented Jan 12, 2025

@PKief so... can I get some feedback again for these icons?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, we having a single colored motive in the front. Here the "qube" has multiple colors on each side and the contrast isn't that good at the moment. Could you please improve that a little bit and check the contribution guidelines again?

@nulkode
Copy link
Contributor

nulkode commented Jan 12, 2025

@PKief I've updated the icons in my fork. Should be this PR closed so I can create a new one? Or can you update this branch with my fork?

@PKief
Copy link
Member Author

PKief commented Jan 12, 2025

@PKief I've updated the icons in my fork. Should be this PR closed so I can create a new one? Or can you update this branch with my fork?

You can create a new one. I'll close this then.

@nulkode nulkode mentioned this pull request Jan 12, 2025
2 tasks
@nulkode
Copy link
Contributor

nulkode commented Jan 12, 2025

You can create a new one. I'll close this then.

@PKief Done. If you can, please give me some feedback.

@PKief PKief closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏞️ icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: BLoC [Icon Request] Flutter Bloc State Management
2 participants