Merge branch 'release-candidate' into stable

material-foundation · Dec 21, 2018 · c3f720c · c3f720c
2 parents 6aec845 + 48a4229
commit c3f720c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 3.0.0
+
+`unused-parameter` has been disabled because it can cause release builds to fail to build when
+using debug-only assertions to check parameters.
+
 # 2.0.0
 
 Added additional warnings to `strict_warnings_objc_library`:

diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@ Add the following to your `WORKSPACE`:
 git_repository(
     name = "bazel_ios_warnings",
     remote = "https://github.com/material-foundation/bazel_ios_warnings.git",
-    tag = "v2.0.0",
+    tag = "v3.0.0",
 )
 ```
 

diff --git a/strict_warnings_objc_library.bzl b/strict_warnings_objc_library.bzl
@@ -39,6 +39,7 @@ COMMON_COPTS = [
     "-Wunused-variable",
     "-Wunused-volatile-lvalue",
     "-Wused-but-marked-unused",
+    "-Wno-unused-parameter",  # Enabled by -Wall via -Wunused, problems with params used in asserts.
 ]
 
 def strict_warnings_objc_library(