Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implementation of quasi-harmonic approximation #891

Closed
wants to merge 19 commits into from

Conversation

JaGeo
Copy link
Member

@JaGeo JaGeo commented Jun 18, 2024

Summary

One way to compute thermodynamic properties of materials is by using the quasi-harmonic approximation. This is an attempt to implement this qha based on the EOS Maker and the harmonic phonon runs.

Closes #890

@JaGeo
Copy link
Member Author

JaGeo commented Jun 20, 2024

@esoteric-ephemera I am adding you as a collaborator to my repo so that you can contribute at a later stage, if you would like to. I would be especially happy about feedback on the EOS - phonon connection. I will try to reuse us much code from the normal EOS fits as possible.

@JaGeo
Copy link
Member Author

JaGeo commented Jun 26, 2024

@esoteric-ephemera Never mind. I think I realized how to use the class correctly without using the make functionality ;). Sorry about this!

@JaGeo
Copy link
Member Author

JaGeo commented Jun 26, 2024

@esoteric-ephemera I think I will also directly use the phonopy api (https://github.com/phonopy/phonopy/blob/develop/phonopy/api_qha.py) to avoid redundant reimplementations. However, this will make different eos available for the qha than in the normal eos fit.

@utf do you think this would be an issue?

@JaGeo JaGeo changed the title WIP: implementation of quasi-harmonic approximation [WIP] Implementation of quasi-harmonic approximation Jun 27, 2024
@JaGeo
Copy link
Member Author

JaGeo commented Jun 27, 2024

ToDo:

  • Reduce number of steps in the workflow
  • Finalize Force field tests
  • Check all units and add field descriptions
  • Document the workflows
  • Fix all linting issues
  • write workflows for the different force fields
  • add a VASP Workflow (with minimal settings)

@JaGeo
Copy link
Member Author

JaGeo commented Jun 28, 2024

I am closing this and reopen. Something seems to be messed up with the tests.

@JaGeo JaGeo closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Quasi-harmonic Approximation
1 participant