Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AliasingErrorHandler checks for 'brmix' #270

Open
xivh opened this issue Jul 12, 2023 · 3 comments
Open

AliasingErrorHandler checks for 'brmix' #270

xivh opened this issue Jul 12, 2023 · 3 comments

Comments

@xivh
Copy link
Contributor

xivh commented Jul 12, 2023

The AliasingErrorHandler checks for a 'brmix' error, but this error is not in the error_msgs dictionary.

https://github.com/materialsproject/custodian/blob/202b941ab9c5d8fc3b9b9e5bb26a9e280ba1e0ea/custodian/vasp/handlers.py#L789C30-L789C30

@Andrew-S-Rosen
Copy link
Member

@xivh: Thanks for reporting, but isn't it found here?

"brmix": ["BRMIX: very serious problems"],

@xivh
Copy link
Contributor Author

xivh commented Jul 12, 2023

I'm not sure because I haven't used the AliasingErrorHandler before, but I didn't see a way for it to get the status of the VaspErrorHandler. The line you linked is from the VaspErrorHandler's error_msgs.

@Andrew-S-Rosen
Copy link
Member

Ah, I believe you're correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants