Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in adding type annotations? #459

Open
berquist opened this issue Oct 15, 2021 · 2 comments · May be fixed by #462
Open

Interest in adding type annotations? #459

berquist opened this issue Oct 15, 2021 · 2 comments · May be fixed by #462

Comments

@berquist
Copy link

Is there interest in adding type annotations to all functions and methods? Checking them with mypy could be done incrementally, using the same nice framework as in #457.

I'm asking because the types in docstrings are already quite complete and are a good starting point, but introspection is improved by adding annotations and I'd be willing to add them.

@mkhorton
Copy link
Member

mkhorton commented Oct 15, 2021 via email

@janosh
Copy link
Member

janosh commented Oct 25, 2021

As a user of FireWorks, I would be strongly in favor of this and think it’s a great idea. I find type annotations very helpful when debugging.

Same.

@berquist berquist linked a pull request Oct 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants