Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values replace the custom input ones in MagneticStructureEnumerator #4184

Open
fraricci opened this issue Nov 19, 2024 · 0 comments
Open

Comments

@fraricci
Copy link
Contributor

I think there is a bug in this line

transformation_kwargs.update(default_transformation_kwargs)

The update method will overwrite the values in the keys of the 'transformation_kwargs' coming from the input, e.g. timeout cannot be changed because of this.

transformation_kwargs={"timeout":1}
default_transformation_kwargs = {"check_ordered_symmetry": False, "timeout": 5}
transformation_kwargs = transformation_kwargs or {}
print(transformation_kwargs)
transformation_kwargs.update(default_transformation_kwargs)
print(transformation_kwargs)

: {'timeout': 1}
: {'timeout': 5, 'check_ordered_symmetry': False}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant