Feedback

[adamwojs]

Hi @mateuszbieniek! I've briefly tested your tool and looked a little bit into the code. Here is my feedback:

• Architecture is correct.
• Can we rename ibexa:redis-check command to ibexa:redis:check or ibexa:redis:info. Judging on code you are expect to have more commands in the future
• Package structure is incorrect (this also apply namespaces) and it's needs to be aligned with ibexa/bundle-generator if you like to move this repository to ibexa organisation.
• Unit and integration tests are missing. See https://symfony.com/doc/current/console.html#testing-commands
• Some dependencies are missing in composer.json e.g. symfony/serialzier used in \MateuszBieniek\IbexaDxpRedisTools\Renderer\JsonCliRenderer
• Redis gateway handles missing db0 key inconsistently. One is throwing \MateuszBieniek\IbexaDxpRedisTools\Redis\Exception\NoDatabaseException, second one \RedisException
• messages translation domain is reserved for applications and should be avoided in reusable packages
• Compatibility with Ibexa DXP v4.x is missing