-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read header document com/mycila/maven/plugin/license/templates/... Cause: null: FileSystemNotFoundException #760
Comments
I have a similar problem with 4.4. Seems the header can no longer be read from the classpath as |
@hazendaz : do you remember a change in this area of the code ? I don't... |
Similar case at scordio/spring-batch-notion#45.
where a built-in license set is used: <plugin>
<groupId>com.mycila</groupId>
<artifactId>license-maven-plugin</artifactId>
<version>4.3</version>
<configuration>
<licenseSets>
<licenseSet>
<header>com/mycila/maven/plugin/license/templates/APACHE-2.txt</header>
<includes>
<include>src/**/*.java</include>
</includes>
</licenseSet>
</licenseSets>
... |
Did a bit of debugging and I think the problem occurs in Lines 66 to 70 in e3cef56
looked like this in v4.3: Lines 63 to 67 in 23a6eb1
Input values are the same (expect that encoding changed) |
Just FYI, assertj/assertj#3464 worked correctly, probably because we use an inline header. |
Thanks for finding the issue. I'm away right now but can look later in the weekend. A pull request would also be great if needed sooner.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Stefano Cordio ***@***.***>
Sent: Wednesday, May 8, 2024 5:42:06 AM
To: mathieucarbou/license-maven-plugin ***@***.***>
Cc: Jeremy Landis ***@***.***>; Mention ***@***.***>
Subject: Re: [mathieucarbou/license-maven-plugin] Cannot read header document com/mycila/maven/plugin/license/templates/... Cause: null: FileSystemNotFoundException (Issue #760)
Just FYI, assertj/assertj#3464<assertj/assertj#3464> worked correctly, probably because we use an inline header.
—
Reply to this email directly, view it on GitHub<#760 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI6CP5JKG2EM5PQMZ5LZBHXO5AVCNFSM6AAAAABHMJJPWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQGE4DENJUGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Probably related problem since upgrade to 4.4
|
Version affected
4.4
Describe the bug
Tonight we got automated dependency updates for your plugin to version 4.4 and all updates have failed in our CI with the following (using
-X
):Tries to search for this file according to debug:
How to Reproduce
We are using the plugin in the following configuration:
https://github.com/xdev-software/testcontainers-junit4-mock/blob/8f7d3ca51962ee84b6d3427010ac5fcb65a53ce4/testcontainers-junit4-mock/pom.xml#L137-L164
CI failure can be seen here:
https://github.com/xdev-software/testcontainers-junit4-mock/actions/runs/8995214856/job/24709844596?pr=8
The text was updated successfully, but these errors were encountered: