From a5de0f91ed515f78f755b90f98776cf2ffd4a8a8 Mon Sep 17 00:00:00 2001
From: Andreas Steiger <andreas.steiger@math.ethz.ch>
Date: Mon, 16 Dec 2024 10:48:55 +0100
Subject: [PATCH] Added overrides for MissingDocblock

---
 classes/event/question_version_imported.php | 12 ++++++------
 classes/form/import_form.php                |  4 ++--
 classes/import_as_version_action_column.php |  8 ++++----
 classes/plugin_feature.php                  |  4 ++--
 classes/privacy/provider.php                |  2 +-
 5 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/classes/event/question_version_imported.php b/classes/event/question_version_imported.php
index c006fc9..f74cb20 100644
--- a/classes/event/question_version_imported.php
+++ b/classes/event/question_version_imported.php
@@ -37,13 +37,13 @@
  */
 class question_version_imported extends question_base {
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     protected function init() {
         parent::init();
         $this->data['crud'] = 'u';
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     protected function validate_data() {
         parent::validate_data();
         if (!isset($this->other['questionbankentryid'])) {
@@ -54,24 +54,24 @@ protected function validate_data() {
         }
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public static function get_name() {
         return get_string('event:question_version_imported', 'qbank_importasversion');
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public function get_description() {
         return "The user with id '$this->userid' imported a new version " .
                 "'{$this->other['version']}' (question id '$this->objectid') of the " .
                 "question bank entry with id '{$this->other['questionbankentryid']}' in course '$this->courseid'.";
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public static function get_objectid_mapping() {
         return ['db' => 'question', 'restore' => 'question'];
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public static function get_other_mapping() {
         return [
             'questionbankentryid' => ['db' => 'question_bank_entries', 'restore' => 'question_bank_entries'],
diff --git a/classes/form/import_form.php b/classes/form/import_form.php
index b3c595c..e75e77d 100644
--- a/classes/form/import_form.php
+++ b/classes/form/import_form.php
@@ -43,7 +43,7 @@
  */
 class import_form extends moodleform {
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     protected function definition() {
         $mform = $this->_form;
 
@@ -107,7 +107,7 @@ protected function validate_uploaded_file($data, $errors) {
         return $errors;
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public function validation($data, $files) {
         $errors = parent::validation($data, $files);
         $errors = $this->validate_uploaded_file($data, $errors);
diff --git a/classes/import_as_version_action_column.php b/classes/import_as_version_action_column.php
index 3db4e7f..9fffcf4 100644
--- a/classes/import_as_version_action_column.php
+++ b/classes/import_as_version_action_column.php
@@ -41,23 +41,23 @@ class import_as_version_action_column extends qbank_importasversion_column_paren
     /** @var string store the value of the name lang string for performance. */
     protected $actionname;
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public function init(): void {
         parent::init();
         $this->actionname = get_string('importasversion', 'qbank_importasversion');
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public function get_name(): string {
         return 'importasversion';
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public function get_menu_position(): int {
         return 650;
     }
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     protected function get_url_icon_and_label(\stdClass $question): array {
         if (!\question_bank::is_qtype_installed($question->qtype)) {
             // It sometimes happens that people end up with junk questions
diff --git a/classes/plugin_feature.php b/classes/plugin_feature.php
index 33642df..b4a824a 100644
--- a/classes/plugin_feature.php
+++ b/classes/plugin_feature.php
@@ -28,7 +28,7 @@
  */
 class plugin_feature extends plugin_features_base {
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public function get_question_actions(view $qbank): array {
         // This is what is used in Moodle 4.3+.
         return [
@@ -37,7 +37,7 @@ public function get_question_actions(view $qbank): array {
     }
 
     // Support multiple Moodle versions. This method can be removed once 4.3 is the lowest supported version.
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public function get_question_columns($qbank): array {
         if (class_exists('\core_question\local\bank\question_action_base')) {
             // We are in Moodle 4.3+. We don't need to implement this method.
diff --git a/classes/privacy/provider.php b/classes/privacy/provider.php
index c4e873d..6c04fd4 100644
--- a/classes/privacy/provider.php
+++ b/classes/privacy/provider.php
@@ -28,7 +28,7 @@
  */
 class provider implements null_provider {
 
-    // phpcs:ignore moodle.Commenting.MissingDocblock.Missing
+    #[\Override]
     public static function get_reason(): string {
         return 'privacy:metadata';
     }