Release v1.0.1

Merge pull request #13 from mathze/develop

Author: mathze

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,31 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: 'bug'
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Data/Screenshots**
+If applicable, add logs, screenshots or other content to help explain your problem and our investigation.
+
+**System (please complete the following information):**
+- Runner-OS: [e.g. ubuntu-latest]
+- Action-Version: [e.g. v1]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,11 @@
+blank_issues_enabled: true
+contact_links:
+  - name: Getting help
+    url: https://github.com/mathze/workflow-dispatch-action/discussions/categories/q-a
+    about: Still not what you need? Have a look in our discussions Q&A
+  - name: Search existing issues
+    url: https://github.com/mathze/workflow-dispatch-action/issues
+    about: If the wiki wasn't helpfull, please check for existing issues.
+  - name: Talk with us
+    url: https://github.com/mathze/workflow-dispatch-action/discussions
+    about: Maybe also this may be interesting

.github/ISSUE_TEMPLATE/enhancement.md

@@ -0,0 +1,22 @@
+---
+name: Enhancement
+about: Suggest an idea for this project
+title: ''
+labels: 'enhancement'
+assignees: ''
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+***Pro's and Con's***
+What are benefits of this alternative and what might its drawbacks.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

CODE_OF_CONDUCT.adoc

@@ -32,7 +32,7 @@ Community leaders have the right and responsibility to remove, edit, or reject c
 This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
 
 == Enforcement
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at mailto:abuse%25qualersoft@gmx.net[abuse%qualersoft@gmx.net,CoC-violation-report]. All complaints will be reviewed and investigated promptly and fairly.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at mailto:abuse%25gh_mathze@gmx.net[abuse%gh_mathze@gmx.net,CoC-violation-report]. All complaints will be reviewed and investigated promptly and fairly.
 
 All community leaders are obligated to respect the privacy and security of the reporter of any incident.
 

CONTRIBUTING.adoc

@@ -1,7 +1,53 @@
-= Contributing to robotframework-gradle-plugin
+= Contributing to workflow-dispatch-action
 :toc:
+:toc-placement!:
+:gh_repo: https://github.com/mathze/workflow-dispatch-action
 
 👍🎉 First off, thanks for taking the time to contributing 🎉👍
+Any kind of contribution is welcome😊
+
+toc::[]
 
 == Code of conduct
 This project and everyone participating in it is governed by the link:CODE_OF_CONDUCT.adoc[Code of Conduct]
+
+== Found a bug?
+* Ensure the bug was not already reported by searching our {gh_repo}/issues[issues]
+* Check for an existing {gh_repo}/discussions[discussion] on your issue
+* If you're unable to find an open issue addressing the problem by creating a {gh_repo}/issues/new?assignees=&labels=&template=bug_report.md&title=[new bug ticket]
+
+== Found a security vulnerability?
+Please refer to our link:SECURITY.adoc[SECURITY] advisory
+
+== Have an improvement idea?
+Very cool! Let's get it into the project!
+
+* First make sure your idea isn't already addressed by a {gh_repo}/issues[feature request] or already in {gh_repo}/discussions[discussion]
+* If a feature request already exists and no one is assigned to it, you can leaf a comment on it that you are interested in work on it or vote for it (see <<Working with issues>>)
+* If there is a discussion about your idea, participate in it.
+* If neither a discussion nor a feature request exists, feel free to create a {gh_repo}/issues/new?assignees=&labels=&template=enhancement.md&title=[new feature request]
+
+== Working with issues
+To keep the information of any issue on its essentials, please respect the following guidelines:
+
+* any discussion shall take place in {gh_repo}/discussions/categories/issues[discuss an issue]. There is no "`golden rule`" from when a discussion in an issue get out of hand, and a discussion should be opened. But a rule of thumb is: "If there are any conflictive opinions, open a discussion"
+* If a discussion about an issue exists it shall be linked.
+* Discussions about an issue must have the issue's id within its title
+* Us 👍 or 👎 on the issue (not a single comment, see <<Discussions on issues>>) to up/down vote it. +
+Note:: Do not add comments like "+1", "-1", "Want that", "Disagree"; Such comments will be deleted.
+
+== Discussions
+{gh_repo}/discussions[Here] is the place where you can share your ideas, ask or answer questions.
+
+=== Discussions on issues
+To up or down vote an idea/comment, use 👍 or 👎 respectively. Avoid cluttering the discussion with "+1", "-1", "like", "dislike" etc. comments. +
+If you write a comment, it should provide value to the discussion.
+
+== Code review
+This project encourages actively reviewing the code, as it will store your precious data, so it's common practice to receive comments on provided patches.
+
+If you are reviewing other contributor's code please consider the following when reviewing:
+
+* Be nice. Please make the review comment as constructive as possible so all participants will learn something from your review.
+
+As a contributor, you might be asked to rewrite portions of your code to make it fit better into the upstream sources.

dist/index.js

@@ -13,15 +13,17 @@ data class WorkflowRun(
 enum class RunStatus(private val value: String) {
   QUEUED("queued"),
   IN_PROGRESS("in_progress"),
-  COMPLETED("completed");
+  COMPLETED("completed"),
+  REQUESTED("requested"),
+  WAITING("waiting");
 
   fun match(restState: String): Boolean = value == restState
 
   companion object {
     fun from(value: String?) = value?.let {
-      values().first {
+      values().firstOrNull {
         it.match(value)
-      }
+      } ?: throw IllegalArgumentException("Cannot map unknown value '$value' to RunStatus!")
     }
   }
 }
@@ -40,7 +42,7 @@ enum class RunConclusion(val value: String) {
     fun from(value: String?) = value?.let {
       values().firstOrNull {
         it.value == value
-      }
+      } ?: throw IllegalArgumentException("Cannot map unknown value '$value' to RunConclusion!")
     }
   }
 }

src/main/kotlin/model/WorkflowRun.kt

@@ -79,17 +79,18 @@ class WorkflowRuns(
 
     // 3. if external ref id is present we check jobs of the runs
     val candidate = if (null != externalRefId) {
-      // before we check we update the 'jobs' entry
       runs.filter {
         // if we have an external ref id we only can consider runs that have jobs
-        it.status != RunStatus.QUEUED
+        it.status != RunStatus.QUEUED &&
+        it.status != RunStatus.REQUESTED &&
+        it.status != RunStatus.WAITING
       }.firstOrNull { run ->
-        // normally here job should never be null (ensured by updateRunDetails)
-        run.jobs!!.let {
-          // before we check we update the jobs entry
+        // normally here the job should never be null (ensured by updateRunDetails)
+        run.jobs?.let {
+          // before we check, we update the jobs entry
           it.fetchJobs(client)
           it.hasJobWithName(externalRefId)
-        }
+        } ?: false // but in case, it is equal to `false` (has no job with name)
       }
     } else { // Otherwise, we take the first closest to dispatch date
       runs.sortedWith(compareBy { it.dateCreated }).firstOrNull()