Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Options Broken #1354

Closed
Brindrajsinh-Chauhan opened this issue Oct 14, 2024 · 4 comments
Closed

CLI Options Broken #1354

Brindrajsinh-Chauhan opened this issue Oct 14, 2024 · 4 comments

Comments

@Brindrajsinh-Chauhan
Copy link

Brindrajsinh-Chauhan commented Oct 14, 2024

System information

Bor client version: v1.4.1

Heimdall client version: v1.0.7

OS & Version: Windows / Linux / OSX

Environment: Polygon Mainnet / Polygon Amoy / Devnet

Issue

DNS Discovery

While trying to use the dns discovery feature for the peering, we tried using the cli flag --discovery.dns to set the value. But that resulted in error below

flag provided but not defined: -discovery.dns

I see the flag present in the codebase here. Is this suppose to be in such a state.

Max Peers

Although we have set --maxpeers 200, we are only seeing 8 outbound peers, which is again making us wonder if maxpeer setting is not taking affect since 1/3 of 25 (default max peer value) is 8 and so out peers are not going up?

Verbosity

When trying to increase verbosity for the node using JS console as follows. But it does not have any affect on the log level.

> debug.verbosity(4)
null

We are setting verbosity as

--verbosity=3

Thank you

@onelapahead
Copy link

We'd like to use --discovery.dns for https://forum.polygon.technology/t/introducing-our-new-dns-discovery-for-polygon-pos-faster-smarter-more-connected/19871 since its the equivalent of the TOML config option mentioned in the blog, and were surprised to see the CLI fail to respect it since its a standard Geth option that was copied over.

@pratikspatil024
Copy link
Member

Hi @Brindrajsinh-Chauhan & @onelapahead - as the error suggests, the cli flag to provide the dns is not available in bor (as we recommend using toml config file), these are the flags available. For now, the only way to add discovery.dns is via the toml config file, but we might add the cli option as well in the future.

Once you set the dns, you will see the number of peers your node is connected with, increase.

@onelapahead
Copy link

Thanks @pratikspatil024 for the steer on where in the code the flags for the server CLI live.

Is there a technical reason for why its not supported as a CLI option aside from preferring users use TOML ? Would you be open to a contribution that were to enable it as a CLI option?

@pratikspatil024
Copy link
Member

We have added the CLI Flag in PR#1355 and is now included in v1.5.0-beta4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants