Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Chain-ID #17

Merged
merged 2 commits into from
May 18, 2023
Merged

Removing Chain-ID #17

merged 2 commits into from
May 18, 2023

Conversation

praetoriansentry
Copy link
Contributor

A few tactical fixes:

  • removing --chain-id from genesis and reading it from L1 Contract
  • Moving rootchain_json_rpc to local variables file
  • Adding commented code that could be used to deploy to Mumbai rather than an unlocked L1 test account

@praetoriansentry praetoriansentry marked this pull request as ready for review May 18, 2023 14:19
@praetoriansentry praetoriansentry requested a review from gatsbyz May 18, 2023 14:19
@praetoriansentry praetoriansentry merged commit b3d11d5 into main May 18, 2023
@praetoriansentry praetoriansentry deleted the jhilliard/mumbai-testing branch May 18, 2023 14:49
@praetoriansentry
Copy link
Contributor Author

Thanks @gatsbyz.

Depending on the root cause of #16 it's possible that this PR will address the issue. cast requires the use of --unlocked in order to send transactions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatsbyz gatsbyz gatsbyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praetoriansentry @gatsbyz