Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ink 4.0 (BREAKING) #253

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AlCalzone
Copy link
Contributor

Note: This PR includes the commit from #252. When #252 is accepted, I can rebase to remove it from the history here.

ink 4.0 is now written in ESM and I had to do some changes to ink-table to make it compatible. Unfortunately, that is a breaking change, since ink-table also needs to be ESM now.

I had to upgrade some dependencies, change how jest is executed, restructure tsconfig to not have VSCode complain in test files. And while I was at it, I changed the default export to a named export (since those have given me too much trouble with bundlers in the past - specifically esbuild).

BREAKING CHANGE: The package is now ESM
@TasoOneAsia
Copy link

@maticzav Is anything holding this back from landing on main?

I'm currently on an ESM project referencing an ESM-compatible fork, but I would prefer to reference the original package if this can get landed.

@dskvr
Copy link

dskvr commented Nov 26, 2023

Appears to be an abandoned project. Someone should just publish this branch to npm as ink-table-v4, any takers?

😄 https://www.npmjs.com/package/@tqman/ink-table

npm install @tqman/ink-table
yarn add @tqman/ink-table
pnpm install @tqman/ink-table

"ts-node": "9.1.1",
"typescript": "4.7.4"
"typescript": "~4.9.5"
},
"peerDependencies": {
"ink": ">=3.0.0",
Copy link

@dskvr dskvr Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>=4.0.0 to suppress warning (peerDependencies)

@lougreenwood
Copy link

Is it expected that this be merged and released anytime soon?

Kenneth-Sills added a commit to Kenneth-Sills/ink-table that referenced this pull request Aug 6, 2024
We aren't ready for ESMs quite yet, see maticzav#253.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants