-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for ink
4.0 (BREAKING)
#253
base: master
Are you sure you want to change the base?
Conversation
BREAKING CHANGE: The package is now ESM
@maticzav Is anything holding this back from landing on I'm currently on an ESM project referencing an ESM-compatible fork, but I would prefer to reference the original package if this can get landed. |
😄 https://www.npmjs.com/package/@tqman/ink-table
|
"ts-node": "9.1.1", | ||
"typescript": "4.7.4" | ||
"typescript": "~4.9.5" | ||
}, | ||
"peerDependencies": { | ||
"ink": ">=3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>=4.0.0
to suppress warning (peerDependencies)
Is it expected that this be merged and released anytime soon? |
We aren't ready for ESMs quite yet, see maticzav#253.
Note: This PR includes the commit from #252. When #252 is accepted, I can rebase to remove it from the history here.
ink
4.0 is now written in ESM and I had to do some changes toink-table
to make it compatible. Unfortunately, that is a breaking change, sinceink-table
also needs to be ESM now.I had to upgrade some dependencies, change how
jest
is executed, restructuretsconfig
to not have VSCode complain in test files. And while I was at it, I changed thedefault
export to a named export (since those have given me too much trouble with bundlers in the past - specificallyesbuild
).