-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename libary to brother_ql2 or similar #58
Comments
I'm definitely in favor of a rename, since this is currently the most actively maintained fork of the original codebase at the moment. This library has a lot of potential, but having to carry the legacy baggage from the original abandoned codebase makes it pretty frustrating to work with. I understand your concern for maintaining backward compatibility, but it would be nice if we can work out a deprecation plan and start to clean up the codebase a bit more. Some more notable things that would be nice to have:
|
I am in general agreement. I consider everything that exists right now as the public API as there was no official distinction made before. Another thing on my mind is to de-couple this repo somehow from the commit-graph of brother_ql. I have already fat-fingered PRs a few times onto brother_ql and would like to remove that possibility. |
The only way to detach a fork on github is to delete and recreate the repo unfortunately. I would recommend just creating a new repo with the new name and replace the readme here with a deprecation notice linking to the new repo. |
I have created a placeholder repo and reserved the brother_ql2 name - will wait a few weeks for more input and than start addressing the topics here. |
just found out you can ask github to detach a repo, keeping all issues and child forks intact. you have to contact support and there's a "visual assistance" (bot) that handles generating the required ticket. |
This was initial meant to be a very inactive fork of brother_ql that is just kept running on modern python / deps. It has seen more activity and interest than I though. Feels wired to have inventree so prominently in the name. It seems that brother_ql2 is free on PyPI so my proposal would be to rename it, release under 2 names for a while with a depreaciation notice and sunset the name brother_ql-inventree in a year or so.
Open to thoughts in all directions, I will leave this open for a few weeks at least before taking any further steps.
The text was updated successfully, but these errors were encountered: