Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support replay of piwik.php and matomo.php #224

Closed
tsteur opened this issue Oct 14, 2018 · 0 comments
Closed

Support replay of piwik.php and matomo.php #224

tsteur opened this issue Oct 14, 2018 · 0 comments

Comments

@tsteur
Copy link
Member

tsteur commented Oct 14, 2018

In matomo-org/matomo#13596 / matomo-org/matomo#12785 we add support for matomo.php as endpoint besides piwik.php. It will also be the default for new installations.

The log importer needs to be adjusted to support replaying those requests when using eg --replay-tracking. It isn't that trivial since we currently can only specify one --replay-tracking-expected-tracker-file=piwik.php file but people might use both piwik.php and matomo.php. By default, the log importer should check for both files.

As for the _record_hits method, we maybe still need to use piwik.php as tracking endpoint until Matomo 4.0 as it could otherwise break the import for existing users. We could set it to matomo.php and hope that if it breaks, users don't automatically delete log files so they can fix the issue and replay again after making matomo.php accessible. But realistically, users might only notice after few weeks that it broke and by then the log files may have been deleted. It's tricky. Maybe we could record into matomo.php by default, and if there is eg a 404, or 403 error, then we track into piwik.php?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants