-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian package for 3.3.0 #62
Comments
@to-go Yes, I'm well aware of this as you can imagine. I just spoke at length with @mattab and we have a plan that I need to action. We're targeting around mid-feb (18/02) if everything goes according to plan. I will use this issue to track my commit so you should be aware of the progresses made. Thanks ref: |
Ok, for the people who are following this thread, I'll be brain-dumping as I progress through. There's a lot of left-over from
Here's an incomplete list of things to do :
|
…e archive flavour. 'matomo', 'piwik' or both if unspecified. - `Usage()` function exists with 1 in case of an error. - related to #62
@mattab I noticed that in scripts/build-package.sh#L439 the script recommends sending an email to Microsoft App Store, but the filename in the message body is Should the script use instead |
…al files - add detection for git-lfs in the local environment - at script exit/termination, remove the temporary build folder - removed hardcoded references to 'piwik' using the current flavour version - when fetching tags, fetch everything and prune old references too - when compressing in zip format apply maximum compression (-9) - fixed an issue where SHA1 wouldn't be displayed in email template - added SHA512 to email template - related to #62
@mattab the latest build script has a few features. It publishes and archive for On your side, if you continue to execute the script as usual, you will publish both Last, if you could review my code changes, that would be great. Cheers |
Hi @aureq Thanks for the update! Feedback:
|
@mattab Have you had a chance to test the latest script version? Would it be possible to publish the matomo package alongside with the piwik package please? |
In order to create a transitional package from 1 - update 2 - duplicate the current repository back into If we do 1 each time we generate a Matomo release, a Piwik release will be generated at the same time and both with share the same version number. This is kind of annoying as it will be confusing to many users, but also because if the transitional package has to be updated, then Matomo will receive a new version at the same time (and vice versa). If we do 2, it create a bit more work and duplicates some work, however we have control over each package independently which is more desirable. Last question is to understand whether an entirely new/forked repository is more appropriate (better visibility) rather than a branch in this repository instead (less management overhead). |
I spoke with @mattab and we both agreed that 2b is the best solution of all. We should be rather close to have a transition package and having Matomo 3.3.0 released at an internal test version. If all goes well then I'll publish version 3.4.0 soon after. |
Hi! Sorry for asking that kind of question, but do you have any approximate timeline for when 3.3/3.4 Debian packages might be available on http://debian.matomo.org? Is it like probably this/next week if things go well, or rather further out? |
Hi @mackuba, Don't be sorry, I'm equally impatient as you are. I'm hoping to have version 3.3.0 out in the next 10 days or so. Maybe less but I can't guarantee due to work commitments (I'm presenting at the AWS Sydney Summit). But definitely keep an eye on this issue as I'll update it as soon as it's available. |
@mattab If it could be possible to have inoticoming installed on the server that would be great. |
inoticoming is installed @aureq 👍 |
Status update for those following this issue.
An important aspect to this is securely transferring my GPG signing keys to my lab EC2 instance. |
Hi @aureq - would it be possible for you to run all the code from the SSH account provided for debian.matomo.org ? This way it's fully backed up, etc. maybe it could make things simpler? |
Hi @mattab and all TL;DR - Remove the human component and automate everything. Long version: @mattab technically yes, but probably not a good idea. It's a shared box, ideally the environment should be tightly controlled bu us only due to sensitive material like GPG signing keys. I also remember it's tricky to get all the packages required installed in a timely manner (I don't have any list either yet). While I'm super time poor at the moment, that Vmware event shows that I need to take the bullet, step up and make the process of creating a
Once the steps above are done:
From a more strategic and long term perspective... I would say this is probably the best initial steps we should be taking. As additional improvements we should consider the following:
Benefits would be:
(*) Cost should be considered on the following items. |
People interested in this issue should follow #64 as well. |
@aureq Sounds all good if you can maintain the EC2 setup so it keeps running for the years ahead....! 👍 I've just release the 3.5.0-b3 using the updated script so you now have both matomo and piwik packages available. All the best for this project and your upcoming event... 🥇 |
Hi! So... are we any closer to a 3.3+ Matomo Debian package than we were in April?... 🙂 (sorry) |
@mackuba I hope so. Aiming for the end of this weekend. |
Status report:
I had to:
|
Status report: Doing this allows me to:
|
Status report:
Both branches have been pushed to Github. The next step is to test the upgrade process as much as possible. |
Status report:
I'm going to publish the other missing versions very soon. |
Status report:
I used the official package repository to upgrade my own Matomo installation. The only hurdle is switching to newer webserver configuration but everything else should be mostly smooth. |
thank you!!! works as advertised. couple of steps necessary, but nothing too difficult.
then and bob's your uncle! again, great job aureq, and thank you VERY much! :) EDIT: there were a couple of minor issues I discovered after deploying this. firstly, make sure you edit the cron job to point to the new files (/usr/share/matomo in place of /usr/share/piwik)...secondly, I had a weird issue with a custom plugin that I needed to cp -Rp over from the piwik dir to the new matomo dir. once I did those things, it appears that all is well. |
thank you, working! |
@jawrat thanks for reporting all the details:
|
@ptr1120 You're absolutely right. Let me fix that quickly. |
@ptr1120 I pushed the updated package. Let me know if this is all good for you. Cheers |
Thanks, installed 3.5.1-2, looks perfect. |
Thank you so much for this development! When updating from the existing package, I just had to do @jawrat's indication to |
Some feedback from someone who has just completed their first migration from Piwik to Matamo. I too had the dangling symlink I also seen the issue with addons. All the native addons migrated successfully but my extra addon installed from the store (free) QueuedTracking failed to transfer. Matomo expected this addon to be there based on the stored config and complained loudly about it. I can only assume it also broke the install but after consulting this thread I moved directly to the On an upgrade ideally both the Piwik and Matomo Aliases in On that note I expected the new tracking code to be fully rebranded and was surprised to see a mentions of Piwik
Perhaps this is just waiting for a fix upstream but since it is likely to require users to do a second rework of their sites tracking code for optimal deployment it is worth special mention It has been suggested that Lastly I am still a bit vague about owners and permissions. This is an area Matomo does quite badly at itself with vague advice and quite a bit of trial and error debates in their forums. I would say that it feels odd to have web assets owned by root:root by default after this upgrade. I think this is something given we have a relatively fixed environment we can do better with. Let this not take away from the excellent work done here. I cannot begin to imagine how much time you have saved me. Kudos Update: I have completed 5 more updates with no new issues. |
fyi indeed we haven't yet fixed it into core: matomo-org/matomo#12785 |
Hi @aureq !
Is it possible to build a Debian package with the latest version 3.3.0 and never the less with the new name Matomo?
Torsten
The text was updated successfully, but these errors were encountered: