Missing Morpheus icons via composer

[flexjoly]

Hi,

We use composer to get matomo in our projects.
For a while now, some icons are missing. As far as I can see it is due to the icons-dir in Morpheus-plugin which is empty.

I read #11617, but this won't fix it for us, since we use the official composer package.

How do we get the icons back?

Thanks in advance,
flexjoly

[Findus23]

Hi,

If you want to use Matomo from this git repostitory you need to do some steps that are already automated on the build.
https://matomo.org/faq/how-to-install/faq_18271/
Especially you need to checkout all submodules using git submodule update --init --recursive.

I am not sure if setup only via composer is supported.

[flexjoly]

Hi,

Thanks for your reply....
But we don't use Matomo from the git repo.... So I cannot do this inside composer....

[Findus23]

I can't think of a way to use all Matomo dependencies with composer.

So I'd recommend you to either use the build from https://builds.matomo.org/ or use git as explained here.

[flexjoly]

I can't think of a way to use all Matomo dependencies with composer.

But that is just what composer is about!

I looked again to #13030 ....

https://packagist.org/packages/piwik/
https://packagist.org/packages/matomo/

Then all the composer users would miss these icons or have to do some special action with git.... because only these icons are missing.... Maybe they even don't use git.....
As far as I know you cannot use git inside the composer-dirs, for the need to be ignored by git....
So that cannot be the solution, I think....

So i guess the composer-package is not complete. Or if it is not maintained then there should be a notification in packagist about that.
But when looking through the issues here, there are tasks to update the composer packages: see #12645, #12519, #12518

[flexjoly]

Images en fonts etc are all there, only the icons are missing.... :-(
Makes no sense....

[Findus23]

Hi,

The reason why the icons aren't there is that they are a completly seperate project (https://github.com/matomo-org/matomo-icons) that is included as a submodule.

You should also be missing misc/log-analytics which is also a submodule.

[flexjoly]

Oops indeed 😿
Yesterday I found that matomo has some git-commands with shell_exec. Online I kept shell_exec disabled, but locally (wamp on windows) it is enabled.
I wonder if that would fix it and when these commands are executed (at composer-install or browser-install). I will look into that. And try some things later on 😬

Thanks for your help and info so far! I will report later how it went.
Greetz!

[Findus23]

Hi,

The git commands are just for development and are not used otherwise. You also don't need the whole tests/ folder.

You can check this script which is used to create the normal matomo zip files from the development version on this repository: https://github.com/matomo-org/matomo-package/blob/master/scripts/build-package.sh

[flexjoly]

Oh ok!!
Thanks, I wil look into that!

[creativecoder]

There is a work around for this, you can see an example in https://github.com/creativecoder/piwik-heroku/blob/master/composer.json

Basically you need to manually define the sub repos, like matomo/matomo-icons, in the "repositories" section of your composer.json file, and require them as dependencies in your project. Then add a "post-install-cmd" in composer.json that copies the dependent packages into the correct folders within vendor/piwik/piwik.

[heitorsilva]

My work around was:
Going inside plugins/Morpheus, deleting empty icons folder, cloning https://github.com/matomo-org/matomo-icons.git, renaming the folder from matomo-icons to icons.