diff --git a/API.php b/API.php index d95bc4f8e..d859f970a 100644 --- a/API.php +++ b/API.php @@ -434,7 +434,7 @@ public function createDefaultContainerForSite($idSite) 'idContainer' => $idContainer, 'idContainerVersion' => $draftVersion, 'type' => MatomoTag::ID, - 'name' => Piwik::translate('TagManager_PageViewTriggerName'), + 'name' => Piwik::translate('TagManager_MatomoTagName'), 'fireTriggerIds' => array($idTrigger), 'parameters' => array( MatomoTag::PARAM_MATOMO_CONFIG => '{{'. Piwik::translate('TagManager_MatomoConfigurationVariableName').'}}' diff --git a/Template/Tag/MatomoTag.php b/Template/Tag/MatomoTag.php index 41bf670f6..412dfd273 100644 --- a/Template/Tag/MatomoTag.php +++ b/Template/Tag/MatomoTag.php @@ -192,7 +192,8 @@ public function getParameters() $this->makeSetting('eventValue', '', FieldConfig::TYPE_STRING, function (FieldConfig $field) { $field->title = Piwik::translate('TagManager_EventValue'); $field->customFieldComponent = self::FIELD_VARIABLE_COMPONENT; - $field->description = Piwik::translate('TagManager_EventValueHelp'); + $field->description = Piwik::translate('TagManager_EventValueDescription'); + $field->inlineHelp = '
' . Piwik::translate('TagManager_EventValueInlineHelp', array('', '')); $field->condition = 'trackingType == "event"'; $field->validators[] = new CharacterLength(0, 500); $field->validators[] = new Numeric(true, true); diff --git a/lang/en.json b/lang/en.json index c10d65b43..760e98005 100644 --- a/lang/en.json +++ b/lang/en.json @@ -394,6 +394,8 @@ "EventNameHelp": "The event's object Name, for example a particular Movie name, or Song name, or File nameā€¦", "EventValue": "Event Value", "EventValueHelp": "The event's value, for example \"50\" as in user has stayed on the website for 50 seconds.", + "EventValueDescription": "Specify a value or choose a variable.", + "EventValueInlineHelp": "%1$sNote:%2$s The value must be %1$snumeric%2$s. Negative values are allowed but non-numeric values will automatically be replaced with 0.", "EventValueException": "The event value can only include numeric values and variables.", "Except": "Except", "ExportDraft": "Export draft", diff --git a/tests/System/expected/test___TagManager.exportContainerVersion_site_default_container.xml b/tests/System/expected/test___TagManager.exportContainerVersion_site_default_container.xml index 6273eeb59..8355e2884 100644 --- a/tests/System/expected/test___TagManager.exportContainerVersion_site_default_container.xml +++ b/tests/System/expected/test___TagManager.exportContainerVersion_site_default_container.xml @@ -26,7 +26,7 @@ 31 Matomo - Pageview + Matomo Analytics active diff --git a/tests/System/expected/test_webContext__TagManager.getAvailableTagTypesInContext.xml b/tests/System/expected/test_webContext__TagManager.getAvailableTagTypesInContext.xml index a51d81867..2220e1197 100644 --- a/tests/System/expected/test_webContext__TagManager.getAvailableTagTypesInContext.xml +++ b/tests/System/expected/test_webContext__TagManager.getAvailableTagTypesInContext.xml @@ -459,8 +459,8 @@ - The event's value, for example "50" as in user has stayed on the website for 50 seconds. - + Specify a value or choose a variable. + <br><strong>Note:</strong> The value must be <strong>numeric</strong>. Negative values are allowed but non-numeric values will automatically be replaced with 0. trackingType == "event" 0