This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Apply rot13 to discord spoilers in unformatted matrix message body #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverting this to a draft while I revise it to use the mxc URI approach proposed in matrix-org/matrix-spec-proposals#2010, which works with spoilered content that isn't composed primarily of ascii alphabet characters. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, spoilered text from a discord message appears verbatim in the unformatted body of the corresponding matrix message. This isn't ideal, since it shows up in contexts such as desktop notifications. My proposal is to display the spoiler contents in rot13, a commonly-used format for spoilers on various platforms that don't offer native spoiler functionality. This preserves the semantics of the spoiler even when HTML display isn't available, and ensures that matrix users won't be shown content they may not have wanted to see.