Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a Slack user posts a message in a Slack Thread, a blank event from the Matrix user running the bridge is posted in the room before the message from Slack #57

Open
thomas-profitt opened this issue Nov 9, 2018 · 3 comments
Labels

Comments

@thomas-profitt
Copy link
Member

screenshot from 2018-11-08 21-43-03

screenshot from 2018-11-08 21-43-54

@zoglesby
Copy link

zoglesby commented Nov 8, 2019

Just want to poke this as I came to report it. It adds a lot of noise too Riot especially in a slack instance that uses a lot of threads.

@wapsi
Copy link

wapsi commented Jan 16, 2020

I'm facing this bug as well. Any workaround available?

@wapsi
Copy link

wapsi commented Jan 22, 2020

It looks like matrix-puppet-slack is generating empty messages with message body content: ' \ufeff' for some reason? So I created an ugly workaround but it works for me (it doesn't fix the root cause but filters these empty messages sent by my user):

After npm install has executed I manually edited files:
node_modules/matrix-js-sdk/lib/client.js
node_modules/matrix-js-sdk/src/client.js
by adding following code

    if (content.body == ' \ufeff') {
        console.log(`Skipping empty event created by matrix-puppet-slack (BUG: https://github.com/matrix-hacks/matrix-puppet-slack/issues/57)`);
        return;
    }

after line:
console.log("sendEvent of type " + eventType + " in " + roomId + " with txnId " + txnId);
And then restarted the matrix-puppet-slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants