Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages with text and attachments that are edited lose all attachments #859

Closed
SethFalco opened this issue Oct 8, 2022 · 4 comments
Closed
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@SethFalco
Copy link
Contributor

  1. Send a message from Discord that contains both content and an attachment
  2. Edit that message on Discord

The message is split into multiple messages on the Matrix side. (Which is fine.)
The attachments first, then the content.

But when the message is edited, the first associated message (the attachment) is edited and replaced with the text content of the edit and other messages remain intact.


Initial message from Discord, a single message that contains both content and an attachment.

image

How it appears in Matrix, 2 messages, first the attachment then the content.

image

I edit the message on the Discord side to change the content.

image

On Matrix, the first of the two messages is replaced with the edited content, but the attachment is lost.

image

@erkinalp
Copy link

erkinalp commented Oct 8, 2022

In Discord API 10 and newer, attachments must be re-supplied when the message is being edited.

@SethFalco
Copy link
Contributor Author

SethFalco commented Oct 8, 2022

I don't think that's the problem.

On Matrix, the message is split, the issue is just that the message with the attachment is being updated instead of the message with the text content.

At least in this particular scenario, the fix would just be to update the 2nd message instead of the 1st.

@jaller94 jaller94 added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. label Oct 10, 2022
@Miepee
Copy link
Contributor

Miepee commented Nov 3, 2022

I wonder if fixing #769 would fix this too.

@SethFalco
Copy link
Contributor Author

Closing this, as it's adequately described in #893, and we don't need the duplicate issues.

@SethFalco SethFalco closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

4 participants