Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm - Ingress configuration QoL fixes #836

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

helm - Ingress configuration QoL fixes #836

wants to merge 2 commits into from
+24 −12

Conversation

Arkaniad
Copy link
Contributor

@Arkaniad Arkaniad commented Nov 7, 2023

Addresses #780 partially on two points:

  • The value of the service port for webhook / appservice was required for ingress configuration, this is passed directly from it's configured port in the services block now
  • Ingress configuration of hosts / paths was unclear and not listed in the values.yaml file, values.yaml file now has proper defaults for the values

@Arkaniad
helm - Clarify host/path configuration, fix link between hookshot ser…
4ed3945 
…vice ports / ingress configuration

Signed-off-by: Rhea Danzey <[email protected]>
@Arkaniad Arkaniad requested a review from a team as a code owner November 7, 2023 17:47
@Arkaniad
Changelog
b22be0f 
Signed-off-by: Rhea Danzey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arkaniad