Support optional MSC3860 redirects #4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See `allow_redirect` across the media endpoints: https://spec.matrix.org/v1.9/client-server-api/#client-behaviour-7
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jan 15, 2024
3 tasks
t3chguy
approved these changes
Jan 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Support optional MSC3860 redirects See `allow_redirect` across the media endpoints: https://spec.matrix.org/v1.9/client-server-api/#client-behaviour-7 * Update the tests * Appease the linter * Add test to appease SonarCloud
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@turt2live I don't know if you noticed, but this PR got removed from the review queue due to failing downstream tests. Looks like you need to make a PR for react-sdk to handle the new URLs that this PR creates. |
|
There is a react-sdk PR: matrix-org/matrix-react-sdk#12142 |
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jan 23, 2024
* Enable redirected media by default See matrix-org/matrix-js-sdk#4007 * Update the tests * Update tests * Update end-to-end tests too
…efaulting to `false` Signed-off-by: Michael Telatynski <[email protected]>
|
After discussing with Travis, to avoid a backwards incompatible change (for tests at least) we've gone with only sending the param if a boolean is passed for the new param |
turt2live
commented
Jan 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Feb 11, 2024
* Enable redirected media by default See matrix-org/matrix-js-sdk#4007 * Update the tests * Update tests * Update end-to-end tests too * Update linkifier to use Media customisation endpoint * Fix tests for new js-sdk behaviour * Fix unchanged file * Fix linkifier * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
allow_redirectacross the media endpoints: https://spec.matrix.org/v1.9/client-server-api/#client-behaviour-7Checklist
Here's what your changelog entry will look like:
✨ Features