Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted trailing slash added to basePath (addTrailingS3Sep should be optional ?) #16

Open
ftrudeau opened this issue Jan 12, 2020 · 0 comments

Comments

@ftrudeau
Copy link

Current usage

basePath set to commit hash, which is intended to be the base directory in S3.
Ex: Set basePath to de40ad249, so that every assets are uploaded into that directory

Current behavior

basePath: de40ad249
Resulting basePath: de40ad249/
Resulting Key: de40ad249//assets/scripts/vendor.js

Note the additional trailing slash automatically appended by the tool, which is effectively creating an empty directory in S3.

Desired behavior

basePath: de40ad249
Resulting basePath: de40ad249
Resulting Key: de40ad249/assets/scripts/vendor.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant