Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up TravelTimeCalculator data structures #2770

Closed
mrieser opened this issue Sep 17, 2023 · 0 comments · Fixed by #2839
Closed

Clean up TravelTimeCalculator data structures #2770

mrieser opened this issue Sep 17, 2023 · 0 comments · Fixed by #2839
Assignees
Labels
code sprint Possible issue(s) for the MATSim code sprint performance performance-related issues

Comments

@mrieser
Copy link
Contributor

mrieser commented Sep 17, 2023

The current TravelTimeCalculator seems overly complicated with multiple variants and levels of inheritance and delegation to store the travel times (on-link or link-to-link).

While developing and performance-tuning SpeedyALT, I made the observation that the travel time lookup adds a larger than expected overhead to the routing.

Looking at the current functionality of TravelTimeCalculator, I think the storage backend (at least for on-link travel times) could be implemented in a more resource-efficient and performance-optimized way, resulting in cleaner code, higher efficiency and better performance.

Maybe related: #1933, #1935

@mrieser mrieser added performance performance-related issues code sprint Possible issue(s) for the MATSim code sprint labels Sep 17, 2023
@mrieser mrieser self-assigned this Sep 17, 2023
@mrieser mrieser moved this to In Progress in CodeSprint 2023 Oct 11, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in CodeSprint 2023 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code sprint Possible issue(s) for the MATSim code sprint performance performance-related issues
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant