Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freight (logistics): remove ShipmentLog #3609

Open
1 of 7 tasks
kt86 opened this issue Nov 29, 2024 · 0 comments
Open
1 of 7 tasks

Freight (logistics): remove ShipmentLog #3609

kt86 opened this issue Nov 29, 2024 · 0 comments
Assignees

Comments

@kt86
Copy link
Contributor

kt86 commented Nov 29, 2024

Die (LSP) Shipments haben derzeit neben ihrem Schedule auch einen eigenen Log. Dieser soll darstellen, was tatsächlich passiert.

Mit zunehmender Nutzung der MATSim-Event Infrastruktur ist dann die Frage, ob nicht diese die Grundlage für alles Weitere seien sollte und nicht so ein "zwischendurch" irgendwie erstelltes Log.
Das würde auch die Anzahl der Objekte deutlich reduzieren, die dafür dann nochmal als Teil-Dubletten angelegt werden...

Das impliziert dann auch, dass die entsprechenden Tests umgebaut werden auf Events-Vergleich -> MATSimTestUtils.compareEventsFile(...)

(Update 24.11.2022 KMT)

  • Alle dies betreffenden Tests erweitern um Events-Vergleich
  • Handling in Hubs noch in Events einbauen (add Events for handling of shipments in hubs matsim-vsp/logistics#48)
  • Update der Test-input Events-Dateien
  • Test gegen ShipmentLogs entfernen
  • dabei eventuell ein paar inhaltliche Checks in Assertion beibehalten?
  • ShipmentLog entfernen
  • Schauen, was dann in den EventHandler alles an Infrastruktur entfernt werden kann.

Had another discussion with KN: We will tread that log somehow as an experienced plan of the shipment.
So it is ok, that it remains.

Will check if we can improve some names, to clarify this.
Moreover, there will be some cleanup / follow-up work to e.g, to separate this “logging” from the productive code a bit. One first idea is to move as much as possible an own class, which will do all the logging in one place instead of having it spread all over the places.

((The logistics repo goes into archive mode, code is not on matims-libs. So the issue is moved from - see there for more information: matsim-vsp/logistics#50 ))

@kt86 kt86 self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant