Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

Merge code into freight contrib -> MATSim-libs #314

Closed
4 of 7 tasks
kt86 opened this issue Oct 11, 2024 · 6 comments · Fixed by matsim-org/matsim-libs#3602
Closed
4 of 7 tasks

Merge code into freight contrib -> MATSim-libs #314

kt86 opened this issue Oct 11, 2024 · 6 comments · Fixed by matsim-org/matsim-libs#3602
Assignees
Labels
withKN Something where I need some input from KN

Comments

@kt86
Copy link
Contributor

kt86 commented Oct 11, 2024

  • move code with history
  • update Readme of freight contrib
  • create a PR
  • discuss with KN
  • move or recreate issues in/to MATSim-libs
  • Update Readme in logistics-repo (point to freight contrib)
  • make logistics-repo read-only
@kt86 kt86 added the withKN Something where I need some input from KN label Oct 11, 2024
@kt86 kt86 self-assigned this Oct 11, 2024
@kt86 kt86 changed the title Merge code into freight contrib in MATSim-libs Merge code into freight contrib -> MATSim-libs Oct 11, 2024
@rewertvsp rewertvsp self-assigned this Nov 4, 2024
@kt86 kt86 moved this from Todo (high priority) to Todo (low priority) in MATSIM advanced weekly hackathon Nov 18, 2024
@rewertvsp
Copy link

Move stuff from repo logistics into the freight contrib

@rewertvsp rewertvsp removed their assignment Nov 18, 2024
@kt86
Copy link
Contributor Author

kt86 commented Nov 25, 2024

@kainagel , @JWJoubert
I am now preparing this merge. The main question I have:

Should I

  1. try to keep the history or
  2. just "copy it over, and we re-start again.. ?

Currently, I prefer 1), because the repo is not too large (my fork shows only 7MB) and we did some changes, I think it would be nice to have it in the history...

@rewertvsp
Copy link

@kainagel , @JWJoubert I am now preparing this merge. The main question I have:

Should I

  1. try to keep the history or
  2. just "copy it over, and we re-start again.. ?

Currently, I prefer 1), because the repo is not too large (my fork shows only 7MB) and we did some changes, I think it would be nice to have it in the history...

prefer 1)

@JWJoubert
Copy link
Collaborator

JWJoubert commented Nov 25, 2024

If (1) is not too involved, @kt86, then sure, that would be preferred. The likelihood of actually using the history is surely much lower.

@kt86
Copy link
Contributor Author

kt86 commented Nov 26, 2024

I have now prepared a draft PR, including the history: matsim-org/matsim-libs#3590

Will discuss this with @kainagel in our meeting on Thursday

@kt86
Copy link
Contributor Author

kt86 commented Nov 27, 2024

New PR is: matsim-org/matsim-libs#3602

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
withKN Something where I need some input from KN
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants