Global error

[bdelville]

This is a open discussion about a particular line of code of the library:

beautify(
                error, collection, values,
                messages, options.defaultMessage
            )
                .then(next)
                .catch(function (beautifyError) {
                    setTimeout(function () {
                        throw new Error(
                            'mongoose-beautiful-unique-validation error: '
                            + beautifyError.stack
                        );
                    });
});

When beautify fails, its send a global error within a setTimeout() instead of propagating the error. Which lead to a crash.

Is this feature strongly required by this library, or should we just call next(aNewError) like this?

beautify(
                error, collection, values,
                messages, options.defaultMessage
            )
                .then(next)
                .catch((beautifyError) => next(beautifyError) );
});

[bdelville]

Closing this and proposing a pull-request instead