From 1ed74eaba01690db9cb1936d4d9e27f03c5ac9de Mon Sep 17 00:00:00 2001 From: Nicolas Villanueva Date: Thu, 19 Oct 2023 16:32:56 -0700 Subject: [PATCH] fix: Release drafts now attach files correctly (#196) --- .github/workflows/release.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ea4f11d0..bdcadb5e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -140,20 +140,18 @@ jobs: # The formatting here is borrowed from reth which borrowed it from Lighthouse (which is borrowed from OpenEthereum): https://github.com/openethereum/openethereum/blob/main/.github/workflows/build.yml run: | body=$(cat <<- "ENDBODY" - Release: ${{ env.VERSION }} - ## 📋 Summary - 🐛 **Bug Fixes:** + ### 🐛 Bug Fixes: - TBD - ✨ **New Features:** + ### ✨ New Features: - TBD - ⚠️ **Breaking Changes:** + ### ⚠️ Breaking Changes: - TBD ## 📜 All Changes @@ -169,6 +167,7 @@ jobs: | System | Architecture | Binary | |:---:|:---:|:---:| | | x86_64 | [era-test-node-${{ env.VERSION }}-x86_64-unknown-linux-gnu.tar.gz](https://github.com/${{ env.REPO_NAME }}/releases/download/${{ env.VERSION }}/era_test_node-${{ env.VERSION }}-x86_64-unknown-linux-gnu.tar.gz) | + | | aarch64 | [era-test-node-${{ env.VERSION }}-aarch64-unknown-linux-gnu.tar.gz](https://github.com/${{ env.REPO_NAME }}/releases/download/${{ env.VERSION }}/era_test_node-${{ env.VERSION }}-aarch64-unknown-linux-gnu.tar.gz) | | | x86_64 | [era-test-node-${{ env.VERSION }}-x86_64-apple-darwin.tar.gz](https://github.com/${{ env.REPO_NAME }}/releases/download/${{ env.VERSION }}/era_test_node-${{ env.VERSION }}-x86_64-apple-darwin.tar.gz) | | | aarch64 | [era-test-node-${{ env.VERSION }}-aarch64-apple-darwin.tar.gz](https://github.com/${{ env.REPO_NAME }}/releases/download/${{ env.VERSION }}/era_test_node-${{ env.VERSION }}-aarch64-apple-darwin.tar.gz) | | | | | @@ -176,7 +175,7 @@ jobs: ) assets=() for asset in ./era_test_node-*.tar.gz*; do - assets+=("-a" "$asset/$asset") + assets+=("$asset/$asset") done tag_name="${{ env.VERSION }}" - echo "$body" | gh release create --draft "${assets[@]}" -F "-" "$tag_name" \ No newline at end of file + echo "$body" | gh release create "$tag_name" "${assets[@]}" --draft -F "-" -t "Release: $tag_name" \ No newline at end of file