You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I feel like this is of very limited usefulness due to the following reasons:
The handler for eth_coinbase is usually disabled for base ETH. I tried 15 different providers and only one of them returned 0x00..00, all others responded with either "unimplemented" or "etherbase must be explicitly specified" (Geth default when --etherbase param is missing).
There is a good reason for the above: coinbase is a consensus layer thing now and it does not make sense for it to be present on the execution layer.
Neither reth nor anvil support eth_coinbase (weirdly enough latter supports anvil_setCoinbase, maybe to manually replicate EVM executions that depend on COINBASE opcode?)
At the same time cost of "faking" support for it is negligible.
The text was updated successfully, but these errors were encountered:
@dutterbutter@popzxc What do you guys think would make the most amount of sense here? I am leaning toward adding a very simple implementation (Arc<RwLock<Address>> that is only used in these two methods) and printing something in the logs about coinbase having no impact on anything in ZKsync.
Also fine with marking them as intentionally unsupported with a similar message.
Two methods to get/set coinbase (aka author/beneficiary/miner):
I feel like this is of very limited usefulness due to the following reasons:
eth_coinbase
is usually disabled for base ETH. I tried 15 different providers and only one of them returned0x00..00
, all others responded with either "unimplemented" or "etherbase must be explicitly specified" (Geth default when--etherbase
param is missing).eth_coinbase
(weirdly enough latter supportsanvil_setCoinbase
, maybe to manually replicate EVM executions that depend onCOINBASE
opcode?)At the same time cost of "faking" support for it is negligible.
The text was updated successfully, but these errors were encountered: