feat: add docker build for amd64 / arm64, e2e tests, publishing ghcr #503
+122
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er node, publishes to ghcr
dutterbutter
commented
Dec 19, 2024
Comment on lines
67
to
68
| us-docker.pkg.dev/matterlabs-infra/matterlabs-docker/era-test-node:${{ steps.docker_tag.outputs.tag }} | ||
| us-docker.pkg.dev/matterlabs-infra/matterlabs-docker/era-test-node:latest |
There was a problem hiding this comment.
@popzxc how can we update this to be anvil-zksync instead of era-test-node?
There was a problem hiding this comment.
I would just try changing the name first and see if that will work. The way I am parsing this string is matterlabs-infra is the name of project, matterlabs-docker is the name of the container registry and era-test-node is the image in the registry. AFAIR you should be able to add new images to an existing registry by default unless we have disabled that on purpose.
There was a problem hiding this comment.
You can temporarily enable on.push.branches.<your-branch-name> to make this trigger before we merge the PR
There was a problem hiding this comment.
dutterbutter
commented
Dec 19, 2024
dutterbutter
added
the
do not merge 🛑
dutterbutter
removed
the
do not merge 🛑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Why ✋
Closes #479, Closes #480, Closes #481
Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intended