From 82b5353a36c8f3402a1f26cec91b78b244b708e7 Mon Sep 17 00:00:00 2001 From: Vasyl Ivanchuk Date: Mon, 5 Feb 2024 18:02:35 +0200 Subject: [PATCH] fix: remove value variable from the CheckBoxInput component --- .../app/src/components/common/CheckBoxInput.stories.ts | 3 --- packages/app/src/components/common/CheckBoxInput.vue | 8 ++------ packages/app/src/views/ContractVerificationView.vue | 1 - .../app/tests/components/common/CheckBoxInput.spec.ts | 4 +--- 4 files changed, 3 insertions(+), 13 deletions(-) diff --git a/packages/app/src/components/common/CheckBoxInput.stories.ts b/packages/app/src/components/common/CheckBoxInput.stories.ts index beeeba7b2a..6f1d6a20fc 100644 --- a/packages/app/src/components/common/CheckBoxInput.stories.ts +++ b/packages/app/src/components/common/CheckBoxInput.stories.ts @@ -6,7 +6,6 @@ export default { }; type Args = { - value: boolean; modelValue: boolean; }; @@ -21,12 +20,10 @@ const Template = (args: Args) => ({ export const Checked = Template.bind({}) as unknown as { args: Args }; Checked.args = { - value: true, modelValue: true, }; export const Unchecked = Template.bind({}) as unknown as { args: Args }; Unchecked.args = { - value: false, modelValue: false, }; diff --git a/packages/app/src/components/common/CheckBoxInput.vue b/packages/app/src/components/common/CheckBoxInput.vue index e0a8323868..04f1de75b6 100644 --- a/packages/app/src/components/common/CheckBoxInput.vue +++ b/packages/app/src/components/common/CheckBoxInput.vue @@ -1,6 +1,6 @@ @@ -18,10 +18,6 @@ const props = defineProps({ type: Boolean, default: null, }, - value: { - type: Boolean, - required: true, - }, }); const emit = defineEmits<{ (eventName: "update:modelValue", value: unknown): void; diff --git a/packages/app/src/views/ContractVerificationView.vue b/packages/app/src/views/ContractVerificationView.vue index 52f01622f1..2bc9272bfa 100644 --- a/packages/app/src/views/ContractVerificationView.vue +++ b/packages/app/src/views/ContractVerificationView.vue @@ -112,7 +112,6 @@ {{ t("contractVerification.form.solcVersion.zkVM") }} diff --git a/packages/app/tests/components/common/CheckBoxInput.spec.ts b/packages/app/tests/components/common/CheckBoxInput.spec.ts index 059c419826..f51e052269 100644 --- a/packages/app/tests/components/common/CheckBoxInput.spec.ts +++ b/packages/app/tests/components/common/CheckBoxInput.spec.ts @@ -13,7 +13,7 @@ describe("CheckBoxInput", () => { }, }, props: { - value: true, + modelValue: true, }, }); expect(container.textContent).toBe("CheckBox Input"); @@ -22,7 +22,6 @@ describe("CheckBoxInput", () => { const { container } = render(CheckBoxInput, { props: { modelValue: true, - value: true, }, }); expect(container.querySelector(".checkbox-input-container")!.classList.contains("checked")).toBe(true); @@ -32,7 +31,6 @@ describe("CheckBoxInput", () => { const { container } = render(CheckBoxInput, { props: { modelValue: false, - value: false, }, }); expect(container.querySelector(".checkbox-input-container")!.classList.contains("checked")).toBe(false);