Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: TEE-verified badge #325

Open
pbeza opened this issue Nov 25, 2024 · 3 comments
Open

Feature Request: TEE-verified badge #325

pbeza opened this issue Nov 25, 2024 · 3 comments

Comments

@pbeza
Copy link

pbeza commented Nov 25, 2024

🌟 Feature Request

📝 Description

We are now generating TEE proofs alongside ZK proofs as part of the multi-prover work. It would be great to show TEE proofs in the block explorer, along with info on how to verify them.

Once we have on-chain verification in place, we can add a badge next to each batch that automatically shows the result of the on-chain TEE proof verification. For now, the best way to verify TEE proofs is by using the Docker image we provide.

🤔 Rationale

Users should be able to easily verify the TEE proofs we produce if they want to.

📋 Additional Context

  • Demo
  • Relevant notion thread
  • Getting the TEE proof for sample batch number 494384 on mainnet:
    curl -X POST \
      -H "Content-Type: application/json" \
      --data '{"jsonrpc": "2.0", "id": 1, "method": "unstable_getTeeProofs", "params": [494384, "sgx"] }' \
      https://mainnet.era.zksync.io
    
  • Verifying the TEE proof for sample batch number 494384 on mainnet:
    docker run -i \
      --rm matterlabsrobot/verify-era-proof-attestation:latest \
      --batch 494384 \
      --rpc https://mainnet.era.zksync.io \
      --sgx-allowed-tcb-levels Ok,SwHardeningNeeded
    
@pbeza pbeza changed the title TEE-verified badge Feature Request: TEE-verified badge Nov 25, 2024
@popzxc
Copy link
Member

popzxc commented Nov 25, 2024

@pbeza Probably this part is to be handled by another issue, since it's not actionable now.

Once we have on-chain verification in place, we can add a badge next to each batch that automatically shows the result of the on-chain TEE proof verification. For now, the best way to verify TEE proofs is by using the Docker image we provide.

Maybe it would be fair to display the badge together with the link to the proof now, even though it's not enforced by L1 contract? We can add hover text on the badge saying that the proof can be verified by anyone, but is currently not enforced by the L1 contract.

@pbeza
Copy link
Author

pbeza commented Nov 25, 2024

Probably this part is to be handled by another issue, since it's not actionable now.

Yep, that was my intention – to leave it for now since we haven’t integrated TEE proof on-chain verification yet.

Maybe it would be fair to display the badge together with the link to the proof now, even though it's not enforced by L1 contract? We can add hover text on the badge saying that the proof can be verified by anyone, but is currently not enforced by the L1 contract.

Sounds fine to me – I don’t have a strong opinion on this. cc-ing @haraldh in case he has a better idea.

@haraldh
Copy link

haraldh commented Nov 28, 2024

Yeah, a Verified by TEE badge which links to a page explaining what it means and how to verify manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants