Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line numbers in contracts source code are not preserved #327

Open
Romsters opened this issue Nov 25, 2024 · 0 comments
Open

Line numbers in contracts source code are not preserved #327

Romsters opened this issue Nov 25, 2024 · 0 comments
Assignees
@tx-nikola
Labels
bug Something isn't working frontend Task requires changes to the frontend implementation

Comments

@Romsters
Copy link
Collaborator

🐛 Bug Report

Contracts source code is displayed with ignorance of line numbers. On different screen resolutions the same source code might have different total lines occupied.

🔄 Reproduction Steps

Check https://sepolia.explorer.zksync.io/address/0x0000000000000000000000000000000000000000#contract. Notice the first file has 15 lines numbered and occupies exactly these 15 lines, now change resolution to 480px and notice that now the code takes more lines.

🤔 Expected Behavior

The number of lines occupied by contract source code should be static and always the same, horizontal scroll should be shown.

😯 Current Behavior

The number of lines occupied by contract source code is different based on resolution.
@Romsters Romsters added the bug Something isn't working label Nov 25, 2024
@tx-nikola tx-nikola self-assigned this Nov 27, 2024
@tx-nikola tx-nikola mentioned this issue Nov 27, 2024
Merged
3 tasks
@tx-nikola tx-nikola added the frontend Task requires changes to the frontend implementation label Nov 27, 2024
tx-nikola added a commit that referenced this issue Dec 6, 2024
@tx-nikola
fix: preserve line numbers in contracts (#332)
0b1a667 
# What ❔
This PR preserves the lines and line numbers in contract view, so that
the code lines don't break into the next line on smaller screens.
When the screen is smaller, the lines are horizontally scrollable.
<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔
PR ensures that the line number always corresponds to the correct line.
Previously, on smaller screens, lines would break to the next line,
causing a mismatch between lines and line numbers.

This is a fix for this issue:
#327
<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
@karelvuong karelvuong mentioned this issue Dec 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tx-nikola tx-nikola

Labels
bug Something isn't working frontend Task requires changes to the frontend implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Romsters @tx-nikola