Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long text in tx reason field looks broken #329

Open
Romsters opened this issue Nov 25, 2024 · 0 comments
Open

Long text in tx reason field looks broken #329

Romsters opened this issue Nov 25, 2024 · 0 comments
Assignees
@tx-nikola
Labels
bug Something isn't working frontend Task requires changes to the frontend implementation

Comments

@Romsters
Copy link
Collaborator

🐛 Bug Report

If transaction failure reason contains some bytecode or long text the UI looks broken. Example: https://sepolia.explorer.zksync.io/tx/0xe8d8ec3d36bc6cbbcf3453fa855fb64b56c547411000a631fd41a6c622ce1d79#overview.

🔄 Reproduction Steps

Open https://sepolia.explorer.zksync.io/tx/0xe8d8ec3d36bc6cbbcf3453fa855fb64b56c547411000a631fd41a6c622ce1d79#overview, check out reason field.

🤔 Expected Behavior

Recommend to use word-break: break-all; for this specific field so it takes multiple lines when needed.

😯 Current Behavior

Long text like bytecode takes a single line and scroll appears.
@Romsters Romsters added the bug Something isn't working label Nov 25, 2024
@tx-nikola tx-nikola self-assigned this Nov 29, 2024
@tx-nikola tx-nikola added the frontend Task requires changes to the frontend implementation label Nov 29, 2024
@tx-nikola tx-nikola mentioned this issue Dec 2, 2024
Merged
3 tasks
tx-nikola added a commit that referenced this issue Dec 4, 2024
@tx-nikola
feat: add break-all to tx reason field (#340)
9317a70 
# What ❔

This PR adds a simple break-all to the reason field of the Transactions
view, so that when the transaction returns the error, it doesn't mess up
the UI - the error text just breaks into next lines.

## Why ❔

When the transaction fails, if the error text is too long, it will make
the whole tx UI scrollable for no reason, so we just add break-all to
fix the UI.
This is a fix for this issue:
#329
Example of a failed transaction and error text that makes the table
scrollable:
https://sepolia.explorer.zksync.io/tx/0xe8d8ec3d36bc6cbbcf3453fa855fb64b56c547411000a631fd41a6c622ce1d79#overview

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tx-nikola tx-nikola

Labels
bug Something isn't working frontend Task requires changes to the frontend implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Romsters @tx-nikola