feat: add option to connect wallet read verified contracts requests #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit bf56410):
(expires Tue, 17 Oct 2023 12:44:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
vasyl-ivanchuk
approved these changes
Oct 9, 2023
Romsters
approved these changes
Oct 9, 2023
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add the option for connecting your MetaMask wallet when masking Read requests for verified contracts. By default, it will still use the default network Provider and behave like before, but if there's a wallet it will use its signer.
Why ❔
This is necessary for functions that rely on
msg.sender, so that it will be passed in correctly.Evidence
Interacting with a
Greeter.solcontract (with & without MetaMask wallet connected):Screen.Recording.2023-10-06.at.5.29.56.PM.mov
Screen.Recording.2023-10-06.at.5.28.46.PM.mov
Interacting with a
Characters.solcontract that relies onmsg.sender(with & without MetaMask wallet connected):Screen.Recording.2023-10-06.at.5.26.15.PM.mov
Screen.Recording.2023-10-06.at.5.27.10.PM.mov
Checklist
zk fmtandzk lint.