Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app to support realtime environment config #78

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

vasyl-ivanchuk
Copy link
Collaborator

@vasyl-ivanchuk vasyl-ivanchuk commented Nov 2, 2023

What ❔

Adjust app so it supports realtime environment config

Why ❔

We need this feature to set different app configs from the CLI

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.

Copy link

github-actions bot commented Nov 2, 2023

API E2E Test Results

206 tests   206 ✔️  38s ⏱️
  14 suites      0 💤
    1 files        0

Results for commit 31e2a52.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 2, 2023

Unit Test Results

       3 files     245 suites   3m 15s ⏱️
1 912 tests 1 911 ✔️ 1 💤 0
1 938 runs  1 937 ✔️ 1 💤 0

Results for commit 31e2a52.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 2, 2023

Visit the preview URL for this PR (updated for commit 31e2a52):

(expires Thu, 09 Nov 2023 19:03:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

@vasyl-ivanchuk vasyl-ivanchuk force-pushed the add-in-memory-app-config branch from 6fd3906 to 9facab6 Compare November 2, 2023 18:47
@vasyl-ivanchuk vasyl-ivanchuk changed the title feat: add in-memory app config feat: app to support realtime environment config Nov 2, 2023
@vasyl-ivanchuk vasyl-ivanchuk merged commit 6d2a403 into main Nov 3, 2023
24 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the add-in-memory-app-config branch November 3, 2023 09:02
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 2.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

pcheremu pushed a commit that referenced this pull request Feb 15, 2024
# What ❔

Adjust app so it supports realtime environment config

## Why ❔

We need this feature to set different app configs from the CLI

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [X] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [X] Tests for the changes have been added / updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants