Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix race conditions in sync_blocks tests #19

Merged
merged 4 commits into from
Oct 31, 2023
Merged

fix: Fix race conditions in sync_blocks tests #19

merged 4 commits into from
Oct 31, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 31, 2023

What ❔

  • Fixes race conditions when advancing ManualClock in the tests for the sync_blocks actor.
  • Fixes incorrect processing of invalid blocks.

Why ❔

Bugs are bad mkay.

@slowli slowli marked this pull request as ready for review October 31, 2023 11:16
@slowli slowli requested a review from pompon0 October 31, 2023 12:10
@pompon0 pompon0 merged commit d6ba662 into main Oct 31, 2023
4 checks passed
@pompon0 pompon0 deleted the aov-bft-365-fix-race-conditions-in-sync_blocks-tests branch October 31, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @pompon0