Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix race condition in network tests #20

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: Fix race condition in network tests #20

merged 2 commits into from
Nov 2, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 31, 2023

What ❔

Fixes a race condition in getting_blocks_from_peers test.

Why ❔

Bugs are bad.

@slowli slowli marked this pull request as ready for review October 31, 2023 14:21
@slowli slowli requested a review from pompon0 as a code owner October 31, 2023 14:21
@slowli slowli requested a review from pompon0 November 2, 2023 10:11
@pompon0 pompon0 merged commit 4210e8c into main Nov 2, 2023
4 checks passed
@pompon0 pompon0 deleted the aov-bft-367-fix-race-conditions-in-network-tests branch November 2, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @pompon0