Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Minor protobuf_build chores #29

Merged
merged 3 commits into from
Nov 9, 2023
Merged

refactor: Minor protobuf_build chores #29

merged 3 commits into from
Nov 9, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Nov 8, 2023

What ❔

Performs minor cleanup for the protobuf_buildcrate, such as using more intelligent local variable names and relying more on syn types.

Why ❔

Improves maintainability.

@slowli slowli marked this pull request as ready for review November 8, 2023 16:01
pompon0
pompon0 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@pompon0 pompon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@slowli slowli merged commit d7361cd into main Nov 9, 2023
4 checks passed
@slowli slowli deleted the aov-bft-372-protobuf_build-chores branch November 9, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoffranca brunoffranca brunoffranca approved these changes

@pompon0 pompon0 pompon0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @pompon0 @brunoffranca