Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move protocol version checks (BFT-383) #44

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

moshababo
Copy link
Contributor

@moshababo moshababo commented Nov 30, 2023

Moving protocol version checks from top-level processing to the input processing of replica and leader, along with other error-producing validation checks.

  • A new error type variant has been added to the 4 message types.
  • The compatibility check has been introduced at the beginning of the processing of each message.
  • 4 tests have been added:
    • leader_prepare_incompatible_protocol_version
    • leader_commit_incompatible_protocol_version
    • replica_prepare_incompatible_protocol_version
    • replica_commit_incompatible_protocol_version

@moshababo moshababo merged commit a7c953d into main Dec 4, 2023
4 checks passed
@moshababo moshababo deleted the protocol_ver_checks branch December 4, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants