chore: Fix l1 coverage in sync layer stable (#1211)

.github/workflows/l1-contracts-ci.yaml

@@ -291,38 +291,42 @@ jobs:
       - name: Run coverage
         run: FOUNDRY_PROFILE=default yarn test:foundry && FOUNDRY_PROFILE=default yarn coverage:foundry --report summary --report lcov
 
-      # TODO: for some reason filtering directories stopped working.
-      # # To ignore coverage for certain directories modify the paths in this step as needed. The
-      # # below default ignores coverage results for the test and script directories. Alternatively,
-      # # to include coverage in all directories, comment out this step. Note that because this
-      # # filtering applies to the lcov file, the summary table generated in the previous step will
-      # # still include all files and directories.
-      # # The `--rc lcov_branch_coverage=1` part keeps branch info in the filtered report, since lcov
-      # # defaults to removing branch info.
-      # - name: Filter directories
-      #   run: |
-      #     sudo apt update && sudo apt install -y lcov
-      #     lcov --remove lcov.info 'test/*' 'contracts/dev-contracts/*' '../lib/forge-std/*' '../lib/murky/*' 'lib/*' '../lib/*' 'lib/' 'deploy-scripts/*' --output-file lcov.info --rc lcov_branch_coverage=1
-
-      # # This step posts a detailed coverage report as a comment and deletes previous comments on
-      # # each push. The below step is used to fail coverage if the specified coverage threshold is
-      # # not met. The below step can post a comment (when it's `github-token` is specified) but it's
-      # # not as useful, and this action cannot fail CI based on a minimum coverage threshold, which
-      # # is why we use both in this way.
-      # - name: Post coverage report
-      #   if: github.event_name == 'pull_request' # This action fails when ran outside of a pull request.
-      #   uses: romeovs/[email protected]
-      #   with:
-      #     delete-old-comments: true
-      #     lcov-file: ./l1-contracts/lcov.info
-      #     github-token: ${{ secrets.GITHUB_TOKEN }} # Adds a coverage summary comment to the PR.
-
-      # - name: Verify minimum coverage
-      #   uses: zgosalvez/github-actions-report-lcov@v2
-      #   with:
-      #     coverage-files: ./l1-contracts/lcov.info
-      #     working-directory: l1-contracts
-      #     minimum-coverage: 85 # Set coverage threshold.
+      - name: Setup LCOV
+        uses: hrishikesh-kadam/setup-lcov@v1
+        with:
+          ref: v1.16
+
+      # To ignore coverage for certain directories modify the paths in this step as needed. The
+      # below default ignores coverage results for the test and script directories. Alternatively,
+      # to include coverage in all directories, comment out this step. Note that because this
+      # filtering applies to the lcov file, the summary table generated in the previous step will
+      # still include all files and directories.
+      # The `--rc lcov_branch_coverage=1` part keeps branch info in the filtered report, since lcov
+      # defaults to removing branch info.
+      - name: Filter directories
+        run: |
+          lcov --ignore-errors unused --remove lcov.info 'test/*' 'contracts/dev-contracts/*' 'lib/*' '../lib/*' 'lib/' 'deploy-scripts/*' --output-file lcov.info --rc lcov_branch_coverage=1
+
+      # This step posts a detailed coverage report as a comment and deletes previous comments on
+      # each push. The below step is used to fail coverage if the specified coverage threshold is
+      # not met. The below step can post a comment (when it's `github-token` is specified) but it's
+      # not as useful, and this action cannot fail CI based on a minimum coverage threshold, which
+      # is why we use both in this way.
+      - name: Post coverage report
+        if: github.event_name == 'pull_request' # This action fails when ran outside of a pull request.
+        uses: romeovs/[email protected]
+        with:
+          delete-old-comments: true
+          lcov-file: ./l1-contracts/lcov.info
+          github-token: ${{ secrets.GITHUB_TOKEN }} # Adds a coverage summary comment to the PR.
+
+      - name: Verify minimum coverage
+        uses: zgosalvez/github-actions-report-lcov@v4
+        with:
+          coverage-files: ./l1-contracts/lcov.info
+          working-directory: l1-contracts
+          minimum-coverage: 83 # TODO(EVM-944): increase threshold to 85
+
 
   # FIXME: restore gas report CI
   # gas-report: