From 0c598cc30df232ad35fa4d9cdbadd43de5d13910 Mon Sep 17 00:00:00 2001
From: streamer45 <cstcld91@gmail.com>
Date: Thu, 16 May 2024 18:07:29 -0600
Subject: [PATCH] Allow rtcd service to be exposed on a privileged port

---
 charts/mattermost-rtcd/Chart.yaml                | 2 +-
 charts/mattermost-rtcd/templates/deployment.yaml | 6 +++---
 charts/mattermost-rtcd/values.yaml               | 3 +++
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/charts/mattermost-rtcd/Chart.yaml b/charts/mattermost-rtcd/Chart.yaml
index bf06067e..7686f0dc 100644
--- a/charts/mattermost-rtcd/Chart.yaml
+++ b/charts/mattermost-rtcd/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: mattermost-rtcd
 description: A Helm chart for Kubernetes to deploy Mattermost's RTCD
 type: application
-version: 1.4.0
+version: 1.5.0
 appVersion: latest
 keywords:
 - mattermost
diff --git a/charts/mattermost-rtcd/templates/deployment.yaml b/charts/mattermost-rtcd/templates/deployment.yaml
index 8e2b6747..cb3d4e2c 100644
--- a/charts/mattermost-rtcd/templates/deployment.yaml
+++ b/charts/mattermost-rtcd/templates/deployment.yaml
@@ -30,7 +30,7 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
       dnsPolicy: ClusterFirstWithHostNet
-      hostNetwork: true
+      hostNetwork: false
       serviceAccountName: {{ include "mattermost-rtcd.serviceAccountName" . }}
       terminationGracePeriodSeconds: {{ .Values.configuration.terminationGracePeriod }}
       securityContext:
@@ -57,11 +57,11 @@ spec:
               hostPort: {{ .Values.service.APIport }}
               protocol: TCP              
             - name: rtc-udp
-              containerPort: {{ .Values.service.RTCport }}
+              containerPort: {{ .Values.service.RTCTargetPort }}
               hostPort: {{ .Values.service.RTCport }}
               protocol: UDP
             - name: rtc-tcp
-              containerPort: {{ .Values.service.RTCport }}
+              containerPort: {{ .Values.service.RTCTargetPort }}
               hostPort: {{ .Values.service.RTCport }}
               protocol: TCP
           livenessProbe:
diff --git a/charts/mattermost-rtcd/values.yaml b/charts/mattermost-rtcd/values.yaml
index fbaeb308..896d2ff7 100644
--- a/charts/mattermost-rtcd/values.yaml
+++ b/charts/mattermost-rtcd/values.yaml
@@ -49,6 +49,7 @@ configuration:
     # RTCD_LOGGER_ENABLEFILE: "\"false\""
     # RTCD_RTC_ICEPORTUDP: "\"8443\""
     # RTCD_RTC_ICEPORTTCP: "\"8443\""
+    # RTCD_RTC_ICEHOSTPORTOVERRIDE: "\"443\""
 
   maxUnavailable: 1     # Only used when updateStrategy is set to "RollingUpdate"
   updateStrategy: RollingUpdate
@@ -69,6 +70,8 @@ service:
   APIport: 8045
   # RTCport is the port (both UDP and TCP) that will serve calls related traffic (i.e. audio,video)
   RTCport: 8443
+  # RTCTargetPort is the port (both UDP and TCP) that the service will be listening on internally (in container).
+  RTCTargetPort: 8443
 
 ingress:
   enabled: false